Small fixes

iden3 · Apr 12, 2024 · da072fa · da072fa
1 parent 4318bc7
commit da072fa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/circuits/lib/utils/claimUtils.circom b/circuits/lib/utils/claimUtils.circom
@@ -286,7 +286,7 @@ template getValueByIndex(){
     value <== mux.out;
 }
 
-// verify that the claim has expiration time and it is less then timestamp
+// verify that provided timestamp is less than claim expiration time
 template verifyExpirationTime() {
     signal input {binary} expirationFlag; // claimFlags[3] (expiration flag) is set
     signal input claim[8];

diff --git a/circuits/lib/utils/idUtils.circom b/circuits/lib/utils/idUtils.circom
@@ -102,6 +102,9 @@ template GatherID() {
 template TakeNBits(n) {
     signal input in;
     signal output out;
+
+    assert(n <= 254);
+
     // We take only n least significant bits from 254 bit number.
     component bits = Num2Bits_strict();
     bits.in <== in;

diff --git a/circuits/onchain/credentialAtomicQueryV3OnChain.circom b/circuits/onchain/credentialAtomicQueryV3OnChain.circom
@@ -29,7 +29,6 @@ issuerLevels - Merkle tree depth level for claims issued by the issuer
 claimLevels - Merkle tree depth level for claim JSON-LD document
 maxValueArraySize - Number of elements in comparison array for in/notin operation if level = 3 number of values for
 comparison ["1", "2", "3"]
-idOwnershipLevels - Merkle tree depth level for personal claims
 onChainLevels - Merkle tree depth level for Auth claim on-chain
 */
 template credentialAtomicQueryV3OnChain(issuerLevels, claimLevels, maxValueArraySize, idOwnershipLevels, onChainLevels) {