Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for "language message" in MacOSX #73

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

bugfix for "language message" in MacOSX #73

wants to merge 5 commits into from

Conversation

jayli
Copy link

@jayli jayli commented Sep 28, 2018

Error detected while processing function 85_readingTimerCallback[1]..378[13]..379[10]..370[16]..vebugger#std#updateMarksForFile[5]
..vebugger#util#listSignsInBuffer[1]..83_listSigns[2]..vebugger#util#EnglishExecute:
line 3:
E197: Cannot set language to "en_US.utf8"

Error detected while processing function <SNR>85_readingTimerCallback[1]..378[13]..379[10]..370[16]..vebugger#std#updateMarksForFile[5]
..vebugger#util#listSignsInBuffer[1]..<SNR>83_listSigns[2]..vebugger#util#EnglishExecute:
line    3:
E197: Cannot set language to "en_US.utf8"
@@ -47,6 +47,8 @@ function! s:f_debugger.invokeReading() dict
endfor
for l:k in keys(l:newLines)
for l:line in l:newLines[l:k]
" remove ANSI Colors
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a separate issue than the language messages one, and deserve a separate PR. With a better commit message.

@idanarye
Copy link
Owner

@kyouryuukunn added this part in #69 to fix a bug with non-english environments. The whole idea - if I understood it correctly - is to set the language to english to avoid that bug in Japanese Vim. If you set it to l:lang that just becomes a big NOP - it does nothing (sets the language to itself) and @kyouryuukunn 's bug returns.

I don't have a mac, nor a Japanese machine (and I'm not going to set my machine to Japanese and lock myself out because I can't set it back...), but I googled a bit and it looks like en_US.utf8 is an alias to en_US.UTF-8 and not all setups accept that alias. So:

  • @jayli - I assume :language language messages en_US.utf8 doesn't work for you, but what happens when you run :language language messages en_US.UTF-8?
  • @kyouryuukunn - Does :language language messages en_US.UTF-8 work for you?

I think en_US.UTF-8 is the canonic locale, so if it works for everyone the fix will be to just use that.

As for using exec when restoring the language - I have no idea how it worked without it in the first place...

@jayli
Copy link
Author

jayli commented Sep 30, 2018

dosn't work, it shows me this
E197: Cannot set language to "language messages en_US.UTF-8"

@kyouryuukunn
Copy link
Contributor

Me too.
'language messages en_US.UTF-8' isn't work in my windows 10 x64

@kyouryuukunn
Copy link
Contributor

Sorry, previous comment is miss.
en_US.UTF-8 works correctly.

@jayli
Copy link
Author

jayli commented Oct 26, 2018

I re-implement it https://github.com/jayli/vim-easydebugger

@skriems
Copy link

skriems commented Apr 4, 2020

@idanarye I ran into this problem too and if set the language to en_US.UTF-8 it works on my Mac. I'm going to check the situation on my Arch machine later but I assume this should work there as well. If so, shall I craft a new PR, so we get that merged finally?

As a sidenote: are you still sort of maintaining this project? These many stalled PR's made me wonder... You probably wanne close those PR's like this one? 🤷‍♂ :)

Edit: on my Arch system it's the same. I had to add the en_US.UTF-8 locale first but then it works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants