sonar configuration

icyfry · Sep 11, 2024 · 5883a94 · 5883a94
1 parent 6a0c4a3
commit 5883a94
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 8 deletions.
diff --git a/.github/workflows/deploy-prod.yml b/.github/workflows/deploy-prod.yml
@@ -6,7 +6,7 @@ on:
       - master
 
 jobs:
-  s3-deploy:
+  build-deploy:
     runs-on: ubuntu-latest
     environment: prod
     steps:
@@ -32,6 +32,12 @@ jobs:
 
     - name: Building the project
       run: pnpm run build:prod
-
+
+    - name: SonarCloud Scan
+      uses: SonarSource/sonarcloud-github-action@master
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
+        SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+
     - name: Deploy static site to S3 bucket
-      run: aws s3 sync ./dist/ ${{ secrets.AWS_S3 }} --delete
+      run: aws s3 sync ./dist/ ${{ secrets.AWS_S3 }} --delete
diff --git a/.github/workflows/deploy-staging.yml b/.github/workflows/deploy-staging.yml
@@ -6,7 +6,7 @@ on:
       - develop
 
 jobs:
-  s3-deploy:
+  build-deploy:
     runs-on: ubuntu-latest
     steps:
 
@@ -31,6 +31,12 @@ jobs:
 
     - name: Building the project
       run: pnpm run build:staging
+
+    - name: SonarCloud Scan
+      uses: SonarSource/sonarcloud-github-action@master
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
+        SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 
     - name: Deploy static site to S3 bucket
-      run: aws s3 sync ./dist/ s3://icyfry-website/staging --delete
+      run: aws s3 sync ./dist/ s3://icyfry-website/staging --delete
diff --git a/README.md b/README.md
@@ -1,6 +1,7 @@
 # Icyfry Website
 
 [![Build and deploy prod version](https://github.com/icyfry/icyfry-website/actions/workflows/deploy-prod.yml/badge.svg)](https://github.com/icyfry/icyfry-website/actions/workflows/deploy-prod.yml)
+[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=icyfry_icyfry-website&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=icyfry_icyfry-website)
 <img src="https://img.shields.io/github/languages/top/icyfry/icyfry-website" />
 
 Source code of [icyfry.bzh](https://icyfry.bzh/)

diff --git a/sonar-project.properties b/sonar-project.properties
@@ -0,0 +1,7 @@
+sonar.projectKey=icyfry_icyfry-website
+sonar.organization=icyfry
+sonar.sources=src
+#sonar.tests=src/tests
+#sonar.javascript.lcov.reportPaths=coverage/lcov.info
+#sonar.coverage.exclusions=**/*.test.*
+#sonar.exclusions=src/tests/*
diff --git a/src/components/MyResume.vue b/src/components/MyResume.vue
@@ -14,12 +14,12 @@
           <p>{{ personalInfo.contact.localisation }}</p>
           <div class="social-links">
             <a :href="sanitizeUrl(personalInfo.social.linkedin)" target="_blank">
-              <img src="/linkedin.png" alt="LinkedIn" class="social-icon">
+              <img src="/linkedin.png" alt="LinkedIn" class="social-icon" rel="noopener">
             </a>
-            <a :href="sanitizeUrl(personalInfo.social.malt)" target="_blank">
+            <a :href="sanitizeUrl(personalInfo.social.malt)" target="_blank" rel="noopener">
               <img src="/malt.png" alt="Malt" class="social-icon">
             </a>
-            <a :href="sanitizeUrl(personalInfo.social.github)" target="_blank">
+            <a :href="sanitizeUrl(personalInfo.social.github)" target="_blank" rel="noopener">
               <img src="/github.png" alt="GitHub" class="social-icon">
             </a>
           </div>