Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated prereq warning to direct users to Transfer Credits menu #339

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Jul 28, 2023

Description

  1. Updated prereq/warning message:
      Prerequisite(s) not met! Missing: {requiredCourses?.join(', ')} 
      <br />
      Already completed prerequisite(s)? Click 'Transfer Credits' at the top of the planner to clear the prerequisite(s).

Screenshots

Before:

After:
Screenshot 2023-07-29 at 3 43 14 AM

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment
  • Delete branch

(optional)

  • Write tests
  • Write documentation

Closes #302

Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. On second thought though, we might want to specify that this is only for transferring credit from another school.

site/src/pages/RoadmapPage/Course.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

Deployed staging instance to https://staging-339.peterportal.org

@KevinWu098 KevinWu098 merged commit bb281e7 into master Sep 20, 2023
2 checks passed
@js0mmer js0mmer deleted the transferTooltip branch September 20, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct the user to transfer credits
2 participants