Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pie Chart no longer has -235px Margins (overflow) #334

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Pie Chart no longer has -235px Margins (overflow) #334

merged 2 commits into from
Aug 29, 2023

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Jul 28, 2023 •
edited by js0mmer
Loading

Description

  1. Replaced hard-coded -235px margins with relative/absolute positioning to center the text within the pie chart

Screenshots

Before:

After:
chrome-capture-2023-6-29 (2)

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment
  • Delete branch

(optional)

  • Write tests
  • Write documentation

Closes #320

js0mmer
js0mmer approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Deployed staging instance to https://staging-334.peterportal.org

@KevinWu098 KevinWu098 merged commit 427c13c into master Aug 29, 2023
2 checks passed
@js0mmer js0mmer deleted the pieOverflow branch August 29, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js0mmer js0mmer js0mmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Horizontal scroll bar on search pop up pie
2 participants
@KevinWu098 @js0mmer