Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grade Dist. No Longer Overflow #333

Merged
merged 4 commits into from
Aug 12, 2023
Merged

Grade Dist. No Longer Overflow #333

merged 4 commits into from
Aug 12, 2023

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Jul 28, 2023

Description

  1. Minor changes to styling to normalize margins and prevent overflow. Basically just reset margins to 0.

Screenshots

Before:

After (search):
chrome-capture-2023-6-29

After (course):
chrome-capture-2023-6-29 (1)

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment
  • Delete branch

(optional)

  • Write tests
  • Write documentation

Closes #306

Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep the dropdown menus left-aligned. I think it stays more consistent with the design of PeterPortal. Really, the width just needs to be constrained on the containing div so it doesn't overflow and it wraps the dropdowns onto the next line.

@KevinWu098 KevinWu098 requested a review from js0mmer August 1, 2023 02:20
@KevinWu098 KevinWu098 changed the title Grade Dist. Dropdowns Centered & No Longer Overflow Grade Dist. No Longer Overflow Aug 1, 2023
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@github-actions
Copy link

Deployed staging instance to https://staging-333.peterportal.org

@KevinWu098 KevinWu098 merged commit ab8844a into master Aug 12, 2023
2 checks passed
@js0mmer js0mmer deleted the gradeDropdownOverflow branch August 12, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grade distribution dropdowns overflow
2 participants