Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): ♻️ degrees endpoint #147

Merged
merged 1 commit into from
May 19, 2024

Conversation

ap0nia
Copy link
Contributor

@ap0nia ap0nia commented May 19, 2024

Just some adjustments I thought would be neater. Too much to include in the GitHub comments.

@ap0nia ap0nia marked this pull request as ready for review May 19, 2024 19:27
@ap0nia ap0nia temporarily deployed to staging-147 May 19, 2024 19:27 — with GitHub Actions Inactive
@ap0nia ap0nia temporarily deployed to staging-147-docs May 19, 2024 19:27 — with GitHub Actions Inactive
@ap0nia ap0nia requested a review from ecxyzzy May 19, 2024 19:27
Copy link
Member

@ecxyzzy ecxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endpoint changes lgtm, definitely cleaner than whatever it was that I implemented lol. Also epic Zod schema transform to tagged union tech 🚀

@ecxyzzy ecxyzzy merged commit 01f5751 into degreeworks-scraper May 19, 2024
4 checks passed
@ecxyzzy ecxyzzy deleted the degreeworks-scraper-endpoint branch May 19, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants