Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrictions filter #618

Closed
wants to merge 15 commits into from
Closed

Restrictions filter #618

wants to merge 15 commits into from

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Jun 6, 2023

Summary

Currently implemented as a filter in CourseRenderPane.tsx, but will soon tm be in PeterPortal 😋

Implemented a dropdown checkbox menu into Legacy / Manual search to allow users to remove courses with certain Restriction codes from appearing in search results.

Checkbox Clicky

Test Plan

Make it work :')

Issues

Closes #595

Additional Notes

I mean gosh darn is the code scuffed, but I'll probably rewrite it when the Peterportal stuff happens

@KevinWu098 KevinWu098 marked this pull request as draft June 6, 2023 02:24
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a one-minute glance, so this isn't comprehensive. Just some things to keep in mind:

  1. The dropdown is no readable with light mode
  2. Idiomatically, the filtering should be done on the API side, I think. @ap0nia?

@KevinWu098
Copy link
Member Author

KevinWu098 commented Jun 6, 2023

Thanks for the feedback 💖

  1. The dropdown is no readable with light mode

100% the styling is giga scuffed and I'll clean it up once the rest is done

  1. Idiomatically, the filtering should be done on the API side, I think. @ap0nia?

100% this as well. Spoke with Eric about it and that's definitely the way I want to go about it.

In the meanwhile, I've been tinkering on a way to just filter the Websoc response while we're in the in-between

@KevinWu098 KevinWu098 added enhancement Improvements to the user experience peter portal labels Jun 7, 2023
@github-actions
Copy link
Contributor

Deployed staging instance to https://staging-618.antalmanac.com

@github-actions github-actions bot added the Stale label Oct 13, 2023
@github-actions github-actions bot removed the Stale label Feb 5, 2024
@KevinWu098
Copy link
Member Author

Closing this 8 month old PR 🥲 in favor of API-sided filtering with icssc/peterportal-api-next#130

@KevinWu098 KevinWu098 closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the user experience peter portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out major/school restrictions
3 participants