-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrictions filter #618
Restrictions filter #618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken a one-minute glance, so this isn't comprehensive. Just some things to keep in mind:
- The dropdown is no readable with light mode
- Idiomatically, the filtering should be done on the API side, I think. @ap0nia?
apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/RestrictionsFilter.tsx
Outdated
Show resolved
Hide resolved
Thanks for the feedback 💖
100% the styling is giga scuffed and I'll clean it up once the rest is done
100% this as well. Spoke with Eric about it and that's definitely the way I want to go about it. In the meanwhile, I've been tinkering on a way to just filter the Websoc response while we're in the in-between |
apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/RestrictionsFilter.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/RestrictionsFilter.tsx
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/RestrictionsFilter.tsx
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/RestrictionsFilter.tsx
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/RestrictionsFilter.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Aponia <[email protected]>
…/RestrictionsFilter.tsx Co-authored-by: Aponia <[email protected]>
Deployed staging instance to https://staging-618.antalmanac.com |
Closing this 8 month old PR 🥲 in favor of API-sided filtering with icssc/peterportal-api-next#130 |
Summary
Currently implemented as a filter in
CourseRenderPane.tsx
, but will soon tm be in PeterPortal 😋Implemented a dropdown checkbox menu into Legacy / Manual search to allow users to remove courses with certain Restriction codes from appearing in search results.
Test Plan
Make it work :')
Issues
Closes #595
Additional Notes
I mean gosh darn is the code scuffed, but I'll probably rewrite it when the Peterportal stuff happens