Fork devgrok's changes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuwCampbell
commented
Apr 24, 2020
|
|
||
| return $ do | ||
| left1 <- left0 | ||
| right1 <- right0 |
There was a problem hiding this comment.
These two are just monadic actions on m, which in our case, is IO. So this could be done with Async.
|
@devgrok It would be great if you could benchmark this one too. |
|
I've added concurrency in the tree merge. |
HuwCampbell
commented
Apr 25, 2020
Comment on lines
+121
to
+123
| concurrently | ||
| (runEitherT $ Stream.next leftStream) | ||
| (runEitherT $ Stream.next rightStream) |
There was a problem hiding this comment.
With a little refactor this does indeed work. Haven't bench marked it though.
The Stream.next will do the merge from further in the tree. I think it should offer pretty good parallelism.
|
Benchmarks here on simulated data reduce memory consumption by 10% and is about 30% faster on my machine. Distributions of keys obviously matters, but it's a very good sign. |
|
@jacobstanley you might find this one interesting. |
HuwCampbell
force-pushed
the
master
branch
3 times, most recently
from
600cb1d to
049a27d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@devgrok This is what I was thinking when I saw your changes.
By pushing the merge earlier, it should become a lot easier to add concurrency.