Reduce array copying when access is linear or affine. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of immutable put.
We elaborate immutable Core functions to avalanche and insert extra Copy operations when updating Arrays (which are usually map ops). This maintains correct semantics when we compile to C and have Arrays as allocated values on the heap with pointers to them. Unfortunately though, some of these copy operations were turning up in our loops, which doesn't make a lot of sense, especially for queries like ``` from ... in group ... in ... ``` We fix this by removing copy operations which can't affect the results by tracking values which could potentially point to them and see if a binding uses it in a non-linear manner.
HuwCampbell
force-pushed
the
topic/linear-array-access
branch
from
5ff26fa to
c748c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We elaborate immutable Core functions to avalanche and insert extra
Copy operations when updating Arrays (which are usually map ops).
This maintains correct semantics when we compile to C and have Arrays
as allocated values on the heap with pointers to them.
Unfortunately though, some of these copy operations were turning up
in our loops, which doesn't make a lot of sense, especially for
queries like
We fix this by removing copy operations which can't affect the results
by tracking values which could potentially point to them and see if
a binding uses it in a non-linear manner.