Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix melt bugs #502

Merged
merged 2 commits into from
Mar 7, 2017
Merged

Fix melt bugs #502

merged 2 commits into from
Mar 7, 2017

Conversation

tranma
Copy link
Contributor

@tranma tranma commented Mar 6, 2017

this fixes two melt/constructor/deadcode bugs:

  • don't replace prim_eq unit unit with unit (needs a default case for fold1)
  • when we have a binding that doesn't get used and is not removed by dead code, melt will not melt it and so constructor won't get rid of it, and we are left with an unmelted value in the end (see Unmelted value in avalanche program #500)

ideally we should have a pass right after FromCore that freshify every name

! @amosr @jystic
/jury approved @amosr @jystic

@amosr
Copy link
Contributor

amosr commented Mar 6, 2017

👍

@jacobstanley
Copy link
Contributor

:shipit:

@tranma tranma force-pushed the topic/verify-melt branch from d3e0aa5 to f6318dd Compare March 6, 2017 07:16
@tranma tranma merged commit e90c4a3 into master Mar 7, 2017
@tranma tranma deleted the topic/verify-melt branch March 7, 2017 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants