Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request: Add Option for Building a Specific Package #35

Closed
wants to merge 13 commits into from

Conversation

mjlee111
Copy link

Summary
This PR adds an option to the GitHub Actions workflow for building a specific package within the repository. Previously, the CI process would build all packages, but with this update, users can now specify a particular package to be built. This enhancement provides more flexibility and efficiency, especially when only one package requires testing or development, reducing overall build times and resource consumption.

Changes
Updated the GitHub Actions workflow to include an input parameter for selecting a specific package.
Modified the CI logic to conditionally build the selected package if specified.
Fallback to building all packages if no specific package is provided.

Benefits
Faster build times when only one package needs to be tested.
Reduces resource usage by skipping unnecessary builds of unrelated packages.
Simplifies the development and testing process for contributors focusing on a single package.

Testing
Verified that the workflow correctly builds only the specified package.
Confirmed that the workflow defaults to building all packages when no package is specified.

threeal
threeal previously approved these changes Oct 21, 2024
FaaizHaikal
FaaizHaikal previously approved these changes Oct 22, 2024
@mjlee111
Copy link
Author

ERROR: matplotlib 3.7.5 has requirement numpy<2,>=1.20, but you'll have numpy 1.17.4 which is incompatible.
Installing collected packages: fonttools, contourpy, kiwisolver, zipp, importlib-resources, cycler, pillow, matplotlib
  Attempting uninstall: zipp
    Found existing installation: zipp 1.0.0
    Not uninstalling zipp at /usr/lib/python3/dist-packages, outside environment /usr
    Can't uninstall 'zipp'. No files were found to uninstall.
Successfully installed contourpy-1.1.1 cycler-0.12.1 fonttools-4.54.1 importlib-resources-6.4.5 kiwisolver-1.4.7 matplotlib-3.7.5 pillow-10.4.0 zipp-3.20.2

Workflow test is not working properly. Might have problems in workflows-test.yml

- Added step to upgrade numpy to the latest version before installing dependencies.
- Ensured matplotlib installation works without version conflicts with numpy.
@mjlee111 mjlee111 dismissed stale reviews from FaaizHaikal and threeal via 0be0ddd November 11, 2024 06:11
@mjlee111 mjlee111 closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants