[Sprint 22/23 / PD-405] [[Feature] Add implementation GRPC #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threeal
requested changes
May 8, 2024
| DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/proto/ninshiki.proto | ||
| ) | ||
|
|
||
| add_library(ninshiki_proto SHARED |
There was a problem hiding this comment.
I suggest not making the ninshiki_proto a shared library, if possible:
Suggested change
| add_library(ninshiki_proto SHARED | |
| add_library(ninshiki_proto |
threeal
reviewed
May 8, 2024
Comment on lines
+19
to
+55
| set(protobuf_MODULE_COMPATIBLE TRUE) | ||
| find_package(Protobuf CONFIG REQUIRED) | ||
| message(STATUS "Using protobuf ${Protobuf_VERSION}") | ||
|
|
||
| find_package(gRPC CONFIG REQUIRED) | ||
| message(STATUS "Using gRPC ${gRPC_VERSION}") | ||
|
|
||
| file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/proto) | ||
| add_custom_command( | ||
| OUTPUT | ||
| "${CMAKE_CURRENT_BINARY_DIR}/proto/ninshiki.pb.cc" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/proto/ninshiki.pb.h" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/proto/ninshiki.grpc.pb.cc" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/proto/ninshiki.grpc.pb.h" | ||
| COMMAND $<TARGET_FILE:protobuf::protoc> | ||
| ARGS | ||
| --grpc_out "${CMAKE_CURRENT_BINARY_DIR}/proto" | ||
| --cpp_out "${CMAKE_CURRENT_BINARY_DIR}/proto" | ||
| -I ${CMAKE_CURRENT_SOURCE_DIR}/proto | ||
| --plugin=protoc-gen-grpc=$<TARGET_FILE:gRPC::grpc_cpp_plugin> | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/proto/ninshiki.proto | ||
| DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/proto/ninshiki.proto | ||
| ) | ||
|
|
||
| add_library(ninshiki_proto SHARED | ||
| "${CMAKE_CURRENT_BINARY_DIR}/proto/ninshiki.pb.cc" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/proto/ninshiki.pb.h" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/proto/ninshiki.grpc.pb.cc" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/proto/ninshiki.grpc.pb.h" | ||
| ) | ||
|
|
||
| target_compile_options(ninshiki_proto PRIVATE -fPIC) | ||
| target_compile_features(ninshiki_proto PUBLIC cxx_std_17) | ||
|
|
||
| target_link_libraries(ninshiki_proto PUBLIC | ||
| protobuf::libprotobuf | ||
| ) |
There was a problem hiding this comment.
It would be better to simplify this flow by creating a function and placing it in an independent gRPC utility package. This way, we could simply do this to generate a Proto library from a Proto file:
find_package(YourGrpcUtilityPackage)
add_proto_library(ninshiki_proto proto/ninshiki.proto)
threeal
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link:
https://ichiro-its.atlassian.net/browse/PD-405?atlOrigin=eyJpIjoiZjcyMmNiZGY0YjQ5NDliYzkxYjhkZjBiODFmODk2OWUiLCJwIjoiaiJ9
Description
Added protobuf for grpc
Type of Change
How Has This Been Tested?
Checklist:
feature/JIRA-ID-SHORT-DESCRIPTIONif has a JIRA ticketenhancement/SHORT-DESCRIPTIONif has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTIONif the change doesn't need to be tested (urgent)