Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature / PD-420] Adapt Kansei Main to Remove Ros Arguments #38

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

hiikariri
Copy link
Contributor

Jira Link:

https://ichiro-its.atlassian.net/browse/PD-420

Description

Adjust the main program of kansei to remove ros arguments because ros2 launch automatically appends --ros-args argument after all cmd arguments.

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

src/kansei_main.cpp Outdated Show resolved Hide resolved
src/kansei_main.cpp Outdated Show resolved Hide resolved
@hiikariri hiikariri requested a review from threeal June 23, 2024 10:50
@hiikariri hiikariri merged commit 98fc145 into master Jun 25, 2024
1 check failed
@hiikariri hiikariri deleted the feature/adapt-main-to-ros2-launch branch June 25, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants