Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - Add Fallent Determinant Options #35

Merged
merged 9 commits into from
Mar 9, 2024

Conversation

FaaizHaikal
Copy link
Contributor

Jira Link:

Description

Added options to use rpy or accelero to determine fallen status.

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

Copy link
Member

@threeal threeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have another suggestion, but let's address it in a separate PR. Since it seems that we'll never change the determinant_type after creating a FallenDeterminant object, why don't we just separate the FallenDeterminant class based on the determinant_type?

src/kansei/fallen/node/fallen_determinant.cpp Outdated Show resolved Hide resolved
@FaaizHaikal FaaizHaikal requested a review from threeal March 3, 2024 13:04
src/kansei/fallen/node/fallen_determinant.cpp Outdated Show resolved Hide resolved
src/kansei/fallen/node/fallen_determinant.cpp Outdated Show resolved Hide resolved
test/node/kansei_node_test.cpp Outdated Show resolved Hide resolved
@FaaizHaikal FaaizHaikal merged commit 6e3e6b9 into master Mar 9, 2024
1 check failed
@FaaizHaikal FaaizHaikal deleted the enhancement/add-fallen-determinant-options branch March 9, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants