[Sprint 11/PI - 154] Akushon Unit Test #31
Conversation
test/action/interpolator_test.cpp
Outdated
| std::vector<tachimawari::joint::Joint> action_manager_joints = action_manager.get_joints(); | ||
|
|
||
| for (int i = 0; i < 20; i++){ | ||
| ASSERT_TRUE(expected_positions[0][i] + max_error > action_manager_joints[i].get_position() |
There was a problem hiding this comment.
You can use EXPECT_NEAR instead, see this.
There was a problem hiding this comment.
Another similar usage as well.
test/action/interpolator_test.cpp
Outdated
| && expected_positions[0][i] - max_error < action_manager_joints[i].get_position()); | ||
| } | ||
|
|
||
| for (int i = 0; i < 1100; i++) |
There was a problem hiding this comment.
Why did you use 1100 for the looping limit?
Can you explain about this?
There was a problem hiding this comment.
the delay for the action is 1 second, so i used 1100 to test whether the action would be done in at least 0.1 seconds after the delay. should i change the value or assign it to a variable?
|
My guess was the |
|
Maybe mas @threeal, any suggestion or comment? |
|
btw pls resolve the warnings @Alffaza |
…kushon-unit-tests
…ushon into feature/akushon-unit-tests
…eature/akushon-unit-tests
Jira Link:
https://ichiro-its.atlassian.net/browse/PI-154
Description
create unit test for node initialization, interpolator, and action creation
Type of Change
How Has This Been Tested?
Checklist:
feature/JIRA-ID-SHORT-DESCRIPTIONif has a JIRA ticketenhancement/SHORT-DESCRIPTIONif has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTIONif the change doesn't need to be tested (urgent)