Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB ObjectIDs can be numeric #80

Open
wants to merge 1 commit into
base: cake2.2
Choose a base branch
from

Conversation

richardwyke
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cb59ca0 on richardwyke:cake2.2 into f99add6 on ichikaway:cake2.2.

@moderndeveloperllc
Copy link

We don't want to remove that block entirely, just have more open conditions:

if (!ctype_xdigit($mixed)) {
return;
}

This will allow for all-digit ids AND help cut-down on the issues with the horrid strlen($mixed) !== 24 condition below it. If you don't want to make the change, I will put in a pull-request to they and clean up that logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants