Add support for dark mode for images #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lammertw
force-pushed
the
images-dark-mode
branch
from
cfc0ca7 to
b31f608
Compare
|
Great news! I was expecting that! |
lammertw
force-pushed
the
images-dark-mode
branch
from
b31f608 to
1df0dd8
Compare
|
Sure, I've updated the PR for #575 and changed the merge target to that branch as well. |
|
Unless you want to merge this functionality before merging #575 in which case I'll make a separate PR |
Merged
|
Any update on this? |
# Conflicts: # resources-generator/src/main/kotlin/dev/icerock/gradle/generator/resources/image/AndroidImageResourceGenerator.kt # resources-generator/src/main/kotlin/dev/icerock/gradle/metadata/resource/ResourceMetadata.kt # resources-generator/src/main/kotlin/dev/icerock/gradle/utils/StringExt.kt
…fix changes in readme
Alex009
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds images dark mode support. Images that have "-dark" added to their name will be recognized as dark mode images. By adding them to a "-night" themes resources folder on Android and giving them the "dark" mode appearance classifier on iOS they are automatically picked up by the Android night theme and iOS dark mode.