Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuration cache #620

Closed
wants to merge 2 commits into from
Closed

Support configuration cache #620

wants to merge 2 commits into from

Conversation

storytellerF
Copy link

@storytellerF storytellerF commented Jan 1, 2024

related issue #474 #311

only samples/compose-resources-gallery enable configuration cache, because it use parent folder's resource-generator, other sample need moko-resource release new artificat.

update jetbrains compose,agp,gradle version is necessary on my mac.

ld: unknown options: -ios_simulator_version_min -sdk_version

jetbrains compose 1.5.11
agp 8.2.0
gradle 8.2
kotlin 1.9.21

@Alex009
Copy link
Member

Alex009 commented Jan 9, 2024

hi @storytellerF . thanks for PR. but i can't see changes for configuration cache. what exactly was done for configuration cache?

@storytellerF
Copy link
Author

storytellerF commented Jan 9, 2024

@Alex009 The main problem is that the task references SourceSet which belongs to gradle model type.
disallowed_types

So, the first commit removed all sourcesets references(remove val modifier).
Like this:
e1a2e28#diff-75e13f2f48c64863ef33c8f435053b77a3f696f60890eb280f9d2cc2e9fe381bL23-L23

I accidentally deleted the org.gradle.configuration-cache=true from compose-resources-gallery. I need to make some changes or just delete second commit.

@storytellerF
Copy link
Author

@Alex009 The configuration-cache of compose-resources-gallery has been enabled.
c0abbcf#diff-c5bc3f5413b74cbba166b46c39ce1293d25af018cd258f7aa5ece60e4b49964aR21

@Alex009
Copy link
Member

Alex009 commented Jan 11, 2024

@storytellerF thanks.
in #575 gradle plugin was rewritten from scratch and also supports configuration cache, so you can stop work on this request and try to check plugin from #575 in your project.
i will publish 0.24.0-beta-1 with #575 soon too

@storytellerF
Copy link
Author

@storytellerF thanks. in #575 gradle plugin was rewritten from scratch and also supports configuration cache, so you can stop work on this request and try to check plugin from #575 in your project. i will publish 0.24.0-beta-1 with #575 soon too

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants