Skip to content

Commit

Permalink
feat: add value to disable crds (cloudnative-pg#20)
Browse files Browse the repository at this point in the history
Signed-off-by: Philippe Scorsolini <[email protected]>
  • Loading branch information
phisco authored Jul 26, 2022
1 parent a507930 commit 765753a
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 4 deletions.
4 changes: 3 additions & 1 deletion RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ In order to release `vX.Y.Z` of the `cloudnative-pg` chart, follow these steps:
[remoteBuild](https://github.com/kubernetes-sigs/kustomize/blob/master/examples/remoteBuild.md)
running: `kustomize build
https://github.com/cloudnative-pg/cloudnative-pg/tree/release-1.16/config/helm/\?ref=v1.16.0`,
take care to set the correct version as ref (v1.15.1 in the example command).
take care to set the correct version as ref (v1.15.1 in the example
command). Also notice that crd generation should be guarded from
`.Values.crds.create`, so please pay attention to maintain that.
1. all the needed files in the
[templates](./charts/cloudnative-pg/templates) directory, you can diff
the previous release yaml w.r.t. the new one to know what should be
Expand Down
1 change: 1 addition & 0 deletions charts/cloudnative-pg/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ CloudNativePG Helm Chart
| config.data | object | `{}` | |
| config.name | string | `"cnpg-controller-manager-config"` | |
| config.secret | bool | `false` | Specifies whether it should be stored in a secret, instead of a configmap |
| crds.create | bool | `true` | |
| fullnameOverride | string | `""` | |
| image.pullPolicy | string | `"IfNotPresent"` | |
| image.repository | string | `"ghcr.io/cloudnative-pg/cloudnative-pg"` | |
Expand Down
2 changes: 2 additions & 0 deletions charts/cloudnative-pg/templates/crds/crds.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.create }}
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
Expand Down Expand Up @@ -10267,3 +10268,4 @@ status:
plural: ""
conditions: []
storedVersions: []
{{- end }}
8 changes: 8 additions & 0 deletions charts/cloudnative-pg/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@
}
}
},
"crds": {
"type": "object",
"properties": {
"create": {
"type": "boolean"
}
}
},
"fullnameOverride": {
"type": "string"
},
Expand Down
3 changes: 3 additions & 0 deletions charts/cloudnative-pg/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ imagePullSecrets: []
nameOverride: ""
fullnameOverride: ""

crds:
create: true

webhook:
port: 9443
mutating:
Expand Down
6 changes: 3 additions & 3 deletions charts/cnpg-sandbox/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# cnpg-sandbox

![Version: 0.4.0](https://img.shields.io/badge/Version-0.4.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.16.0](https://img.shields.io/badge/AppVersion-1.16.0-informational?style=flat-square)
![Version: 0.5.0](https://img.shields.io/badge/Version-0.5.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.16.0](https://img.shields.io/badge/AppVersion-1.16.0-informational?style=flat-square)

A sandbox for CloudNativePG

Expand All @@ -20,7 +20,7 @@ A sandbox for CloudNativePG

| Repository | Name | Version |
|------------|------|---------|
| https://cloudnative-pg.github.io/charts | cloudnative-pg | 0.13.0 |
| https://cloudnative-pg.github.io/charts | cloudnative-pg | 0.14.0 |
| https://prometheus-community.github.io/helm-charts | kube-prometheus-stack | 32.2.1 |

## Values
Expand All @@ -34,4 +34,4 @@ A sandbox for CloudNativePG
| kube-prometheus-stack.grafana.adminPassword | string | `"prom-operator"` | the grafana admin password |

----------------------------------------------
Autogenerated from chart metadata using [helm-docs v1.10.0](https://github.com/norwoodj/helm-docs/releases/v1.10.0)
Autogenerated from chart metadata using [helm-docs v1.11.0](https://github.com/norwoodj/helm-docs/releases/v1.11.0)

0 comments on commit 765753a

Please sign in to comment.