Add rotation for viewer widget #2467
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A post to keep a track on the state of PR, what's working and what's not. 2024-09-30.21-01-58.mp4I didn't notice other problems, it's the only blocker for this PR to be ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is a follow-up from #2334 and #2330, and it introduces a
rotationproperty forviewerwidget.Right now it includes basic stuff and I think it's best behavior is when using together with
ContentFit::None, however, all the otherContentFit's are not working as good as this one, and that especially noticable when usingFill(try zooming in/out and changing window sizes when the image is rotated and you'll see).Would be glad if @DKolter or anyone else could help with further implementation for this :)