Fix dev jsxruntimepath #383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wssgcg1213
reviewed
Sep 29, 2022
| @@ -4,6 +4,8 @@ import { TaskName } from '../types.js'; | |||
| import type { UserConfig } from '../types.js'; | |||
| import type { Config, ModuleConfig } from '@swc/core'; | |||
|
|
|||
| const __DEV__ = `${process.env.NODE_ENV === 'development'}`; | |||
There was a problem hiding this comment.
这里不应该直接判断好是 dev 还是 production 吗
|
DEV 和 process.env.NODE_ENV 是两个变量, 在目前最新的 1.3.0 版本已经修复掉了, 感谢你的 PR, 这里先 Close 了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
__DEV__define andjsx-runtimenot found in monorepo