feat: 🎸 report size #335
Merged
feat: 🎸 report size #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maoxiaoke
commented
Apr 22, 2022
maoxiaoke
commented
- closes 输出 bundle 的文件大小 & gzip 信息 #292
ClarkXia
reviewed
Apr 22, 2022
imsobear
reviewed
Apr 22, 2022
packages/pkg/src/types.ts
Outdated
| @@ -48,7 +52,7 @@ export type PkgPluginAPI = IPluginAPI<TaskConfig>; | |||
|
|
|||
| export type PkgPlugin = IPlugin<TaskConfig>; | |||
|
|
|||
| export type TaskName = 'pkg-cjs' | 'pkg-esm' | 'pkg-es2017' | 'pkg-dist-es5' | 'pkg-dist-es2017'; | |||
| export type TaskName = 'cjs' | 'esm' | 'es2017' | 'dist-es5' | 'dist-es2017'; | |||
There was a problem hiding this comment.
- cjs -> transform-cjs
- dist-es5 -> bundle-es5
这样会好点吗？
There was a problem hiding this comment.
我看好多地方用到这个变量，建议通过 constants 抽象掉，改起来也好改一些。
ClarkXia
reviewed
Apr 25, 2022
| // Configure task outputDir（Taskname 以 pkg-[cjs|esm|es2017 命名]） | ||
| normalizedConfig.outputDir = outputDir || join(rootDir, taskName.split('-')[1]); | ||
| // Configure task outputDir | ||
| normalizedConfig.outputDir = outputDir || getOutputDir(rootDir, taskName as TaskName); |
There was a problem hiding this comment.
ctx 已经定义了 PkgContext，这里的 TaskName 的断言是不是多余了
There was a problem hiding this comment.
嗯，build-scripts 返回的还是 string 类型，需要支持一下
There was a problem hiding this comment.
There was a problem hiding this comment.
ClarkXia
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.