Fix I18n.load_path ordering conflicts with rails_i18n #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've looked through the linked discussions and haven't really seen any movement on them recently. We've solved this for our own application by monkey patching |
|
@brianswko Thanks for the fix - we issued the same problem and your solution worked great. Are there any plans to merge it into master? |
|
poke @seejohnrun ☝🏻 |
|
This looks good to me @seejohnrun |
krtschmr
approved these changes
Oct 23, 2021
|
Thank you! Do you mind making a quick update to the |
pacso
approved these changes
Oct 25, 2021
|
So looks like this PR stuck only because missing record for CHANGELOG? |
|
Yes. welcome to open source development 😢 |
|
this just hit me by way of flaky test failures on ci. the problem is that the proper way would be to either
messed up load path: |
glaszig
added a commit
to glaszig/ice_cube
that referenced
this pull request
Nov 9, 2023
ice_cube would inject its locale files at the end of I18n.load_path due to its I18n module being autoloaded and thereby overwrite any customisation the user may have made in other locale files earlier in the laod path. i fix this by injecting ice cube locales at gem load time so that the user has a chance to modify locale keys. this also eliminates a bunch of delegation having a custom I18n module; IceCube::I18n is just the same as ::I18n if the i18n gem is available. resolves ice-cube-ruby#489, ice-cube-ruby#432, ice-cube-ruby#431
glaszig
added a commit
to glaszig/ice_cube
that referenced
this pull request
Nov 9, 2023
ice_cube would inject its locale files at the end of `I18n.load_path` due to its `IceCube::I18n` module being `autoload`ed and thereby overwrite any customisation the user may have made in other locale files earlier in the load path. i fix this by injecting ice cube locales at gem load time so that the user has a chance to modify locale keys later. this also eliminates a bunch of delegation having a custom I18n module; `IceCube::I18n` is just the same as ::I18n if the i18n gem is available. resolves ice-cube-ruby#489, ice-cube-ruby#432, ice-cube-ruby#431
glaszig
added a commit
to glaszig/ice_cube
that referenced
this pull request
Nov 9, 2023
ice_cube would inject its locale files at the end of `I18n.load_path` due to its `IceCube::I18n` module being `autoload`ed and thereby overwrite any customisation the user may have made in other locale files earlier in the load path. i fix this by injecting ice cube locales at gem load time so that the user has a chance to modify locale keys later. this also eliminates a bunch of delegation having a custom I18n module; `IceCube::I18n` is just the same as ::I18n if the i18n gem is available. resolves ice-cube-ruby#489, ice-cube-ruby#432, ice-cube-ruby#431
glaszig
added a commit
to glaszig/ice_cube
that referenced
this pull request
Nov 9, 2023
ice_cube would inject its locale files at the end of `I18n.load_path` due to its `IceCube::I18n` module being `autoload`ed and thereby overwrite any customisation the user may have made in other locale files earlier in the load path. i fix this by injecting ice cube locales at gem load time so that the user has a chance to modify locale keys later. this also eliminates a bunch of delegation having a custom I18n module; `IceCube::I18n` is just the same as ::I18n if the i18n gem is available. resolves ice-cube-ruby#489, ice-cube-ruby#432, ice-cube-ruby#431
glaszig
added a commit
to glaszig/ice_cube
that referenced
this pull request
May 28, 2024
ice_cube would inject its locale files at the end of `I18n.load_path` due to its `IceCube::I18n` module being `autoload`ed and thereby overwrite any customisation the user may have made in other locale files earlier in the load path. i fix this by injecting ice cube locales at gem load time so that the user has a chance to modify locale keys later. this also eliminates a bunch of delegation having a custom I18n module; `IceCube::I18n` is just the same as ::I18n if the i18n gem is available. resolves ice-cube-ruby#489, ice-cube-ruby#432, ice-cube-ruby#431
pacso
pushed a commit
that referenced
this pull request
May 30, 2024
* fix I18n.load_path injection ice_cube would inject its locale files at the end of `I18n.load_path` due to its `IceCube::I18n` module being `autoload`ed and thereby overwrite any customisation the user may have made in other locale files earlier in the load path. i fix this by injecting ice cube locales at gem load time so that the user has a chance to modify locale keys later. this also eliminates a bunch of delegation having a custom I18n module; `IceCube::I18n` is just the same as ::I18n if the i18n gem is available. resolves #489, #432, #431 * use __dir__ expansion instead of __FILE__ * disable linter for I18n gymnastics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #432 and #431
Since
ice_cube's translation files are different from the defaults inrails-i18n, the translations are incorrect whenice_cubegets loaded.For example, in french for the abbreviated form of January:
rails-18nusesjan.https://github.com/svenfuchs/rails-i18n/blob/0cb422dc111b2dfa61a19b4740d04e72fb082d17/rails/locale/fr.yml#L23ice_cubeusesJanhttps://github.com/seejohnrun/ice_cube/blob/d4443a29de12d277e04fede34df4d0e626a9634e/config/locales/fr.yml#L124When
ice_cubegets loaded, it overrides the default resulting in incorrect formatting. This change checks for the presence ofrails_i18nin the load path. If it exists, it insertsice_cube's files before them so that conflicts get overridden by the defaults. Ifrails_i18nis not in use, then they get added to the end of the load path.