Skip to content

Commit

Permalink
fix bug which hid a test case. add a consistency case. lint check for…
Browse files Browse the repository at this point in the history
… cross-suite dependencies. update integration test so it does its own EPP stuff
  • Loading branch information
gbicann committed Jan 24, 2024
1 parent 1c50121 commit cbe3a8c
Show file tree
Hide file tree
Showing 7 changed files with 3,239 additions and 2,853 deletions.
56 changes: 44 additions & 12 deletions inc/epp/cases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ epp-01:
- EPP_TLS_CERTIFICATE_CHAIN_MISSING
- EPP_TLS_CERTIFICATE_HOSTNAME_MISMATCH
- EPP_TLS_BAD_CIPHER

epp-02:
Summary: Protocol conformance test
Description: |
Expand Down Expand Up @@ -86,6 +87,7 @@ epp-02:
- EPP_GREETING_DOES_NOT_MATCH
Input-Parameters:
Dependencies:

epp-03:
Summary: Authentication test
Description: |
Expand All @@ -110,6 +112,7 @@ epp-03:
Input-Parameters:
Resources:
Errors:

epp-04:
Summary: Domain <check> command test
Description: |
Expand All @@ -135,6 +138,7 @@ epp-04:
- EPP_DOMAIN_CHECK_VALID_DOMAIN_INCORRECT_AVAIL
- EPP_DOMAIN_CHECK_INVALID_DOMAIN_INCORRECT_AVAIL
- EPP_DOMAIN_CHECK_REGISTERED_DOMAIN_INCORRECT_AVAIL

epp-05:
Summary: Host <check> command test (if applicable)
Description: |
Expand All @@ -160,6 +164,7 @@ epp-05:
- EPP_HOST_CHECK_VALID_HOST_INCORRECT_AVAIL
- EPP_HOST_CHECK_INVALID_HOST_INCORRECT_AVAIL
- EPP_HOST_CHECK_REGISTERED_HOST_INCORRECT_AVAIL

epp-06:
Summary: Contact <check> command test (if applicable for the registry type)
Description: |
Expand All @@ -181,6 +186,7 @@ epp-06:
- EPP_CONTACT_CHECK_VALID_CONTACT_ID_INCORRECT_AVAIL
- EPP_CONTACT_CHECK_INVALID_CONTACT_ID_INCORRECT_AVAIL
- EPP_CONTACT_CHECK_REGISTERED_CONTACT_ID_INCORRECT_AVAIL

epp-07:
Summary: Contact <create> command test (if applicable for the registry type)
Description: |
Expand Down Expand Up @@ -245,6 +251,7 @@ epp-07:
- EPP_CONTACT_CREATE_INFO_RESPONSE_MISSING_OR_INCORRECT_CC
- EPP_CONTACT_CREATE_INFO_RESPONSE_MISSING_OR_INCORRECT_VOICE
- EPP_CONTACT_CREATE_INFO_RESPONSE_MISSING_OR_INCORRECT_EMAIL

epp-08:
Summary: Contact object access control (if applicable)
Description: |
Expand All @@ -263,6 +270,7 @@ epp-08:
Errors:
- EPP_CONTACT_INFO_RESPONSE_NOT_2201
- EPP_CONTACT_UPDATE_RESPONSE_NOT_2201

epp-09:
Summary: Contact <update> command test (if applicable for the registry type)
Description: |
Expand Down Expand Up @@ -319,11 +327,12 @@ epp-09:
- EPP_CONTACT_UPDATE_INFO_RESPONSE_MISSING_OR_INCORRECT_CC
- EPP_CONTACT_UPDATE_INFO_RESPONSE_MISSING_OR_INCORRECT_VOICE
- EPP_CONTACT_UPDATE_INFO_RESPONSE_MISSING_OR_INCORRECT_EMAIL

epp-10:
Summary: Contact <delete> command test (if applicable for the registry type)
Description: |
This test will perform `<delete>` commands on the objects created during
`epp-22` and will confirm that the server accepts the `<delete>` command
`epp-24` and will confirm that the server accepts the `<delete>` command
with a `1xxx` response code.
If the `general.minimalPublicDataSet` input parameter is `true`, this
Expand All @@ -339,6 +348,7 @@ epp-10:
Errors:
- EPP_CONTACT_DELETE_RESPONSE_NOT_1000_OR_1001
- EPP_CONTACT_DELETE_OBJECT_STILL_EXISTS

epp-11:
Summary: host <create> command test (if applicable)
Description: |
Expand Down Expand Up @@ -374,6 +384,7 @@ epp-11:
- EPP_HOST_CREATE_SERVER_ACCEPTS_INVALID_STATUS_CODE
- EPP_HOST_CREATE_INFO_RESPONSE_OBJECT_DOES_NOT_EXIST
- EPP_HOST_CREATE_INFO_RESPONSE_MISSING_OBJECT_PROPERTIES

epp-12:
Summary: Host object access control (if applicable)
Description: |
Expand All @@ -390,6 +401,7 @@ epp-12:
- epp-11
Errors:
- EPP_HOST_UPDATE_AUTHZ_ERROR

epp-13:
Summary: Host <update> command test (if applicable)
Description: |
Expand Down Expand Up @@ -422,6 +434,7 @@ epp-13:
- EPP_HOST_UPDATE_SERVER_ACCEPTS_INVALID_STATUS_CODE
- EPP_HOST_UPDATE_INFO_RESPONSE_OBJECT_DOES_NOT_EXIST
- EPP_HOST_UPDATE_INFO_RESPONSE_MISSING_OBJECT_PROPERTIES

epp-14:
Summary: Domain <create> command test
Description: |
Expand Down Expand Up @@ -496,6 +509,7 @@ epp-14:
- EPP_DOMAIN_CREATE_SERVER_ACCEPTS_AUTHINFO
- EPP_DOMAIN_CREATE_INFO_RESPONSE_INVALID_ROID
- EPP_DOMAIN_CREATE_INFO_RESPONSE_MISSING_OBJECT_PROPERTIES

epp-15:
Summary: Registry object integrity test
Description: |
Expand All @@ -514,6 +528,7 @@ epp-15:
Errors:
- EPP_INTEGRITY_SERVER_ACCEPTS_DELETE_FOR_LINKED_CONTACT_OBJECT
- EPP_INTEGRITY_SERVER_ACCEPTS_DELETE_FOR_LINKED_HOST_OBJECT

epp-16:
Summary: Domain <update> command test
Description: |
Expand Down Expand Up @@ -546,7 +561,24 @@ epp-16:
- EPP_DOMAIN_UPDATE_INFO_RESPONSE_MISSING_REGISTRANT
- EPP_DOMAIN_UPDATE_INFO_RESPONSE_UNEXPECTED_DNSSEC_DATA
- EPP_DOMAIN_UPDATE_INFO_RESPONSE_MISSING_DNSSEC_DATA
epp-16:

epp-17:
Summary: Service Port consistency test
Description: |
This test confirms that all EPP service ports respond with consistent object
information.
The client will establish seperate connections to each EPP service port
(defined as an IP address and TCP port) and perform `<info>` commands on the
objects created in `epp-14`. In all cases, the server **MUST** respond with
a `1000` response and the content of the `<infData>` element **MUST** be
identical on all service ports.
Dependencies:
- epp-14
Errors:
- EPP_SERVICE_PORT_NOT_CONSISTENT

epp-18:
Summary: Domain <renew> command test
Description: |
This test will confirm that the client is able to renew domain names. The
Expand All @@ -570,7 +602,7 @@ epp-16:
- EPP_RENEW_INFO_RESPONSE_UNEXPECTED_EXPIRY_DATE
- EPP_RENEW_INFO_RESPONSE_MISSING_OR_INVALID_RGP_STATUS

epp-17:
epp-19:
Summary: Domain <transfer> command test
Description: |
This test will confirm that the client is able to initiate a domain
Expand Down Expand Up @@ -625,13 +657,13 @@ epp-17:
- EPP_TRANSFER_INFO_RESPONSE_MISSING_OR_INVALID_RGP_STATUS
- EPP_TRANSFER_INFO_RESPONSE_AUTHINFO_NOT_RESET

epp-18:
epp-20:
Summary: Domain <transfer> rejection test
Description:
This test confirms that the server behaves correctly if the sponsoring
registrar of a domain rejects a transfer request.

The test procedure matches that of `epp-17`, but the transfer request will
The test procedure matches that of `epp-19`, but the transfer request will
be rejected rather than approved. An `<info>` command will be used to
confirm that the domain name remains under the sponsorship of the original
registrar.
Expand All @@ -640,7 +672,7 @@ epp-18:
Errors:
- EPP_TRANSFER_SERVER_PROCESSED_REJECTED_TRANSFER

epp-19:
epp-21:
Summary: Domain <delete> command test
Description: |
This test will perform `<delete>` commands on the objects created during
Expand All @@ -662,11 +694,11 @@ epp-19:
- EPP_DOMAIN_DELETE_INFO_RESPONSE_OBJECT_NOT_PENDING_DELETE
- EPP_DOMAIN_DELETE_INFO_RESPONSE_RGP_STATUS_NOT_PENDING_DELETE

epp-20:
epp-22:
Summary: Domain restore test
Description: |
This test will perform RGP restore operations on the objects deleted
during `epp-19`, in order to confirm the correct operation of the server's
during `epp-21`, in order to confirm the correct operation of the server's
implementation of RFC 3915.
Once the restore request has been procssed, the client will perform
Expand All @@ -675,11 +707,11 @@ epp-20:
Input-Parameters:
- epp.restoreReportRequired
Dependencies:
- epp-19
- epp-21
Errors:
- EPP_RESTORE_DOMAIN_STILL_PENDINGDELETE

epp-21:
epp-23:
Summary: Host rename test (if applicable)
Description: |
This tests verifies the server's support for host rename operations.
Expand Down Expand Up @@ -717,7 +749,7 @@ epp-21:
- EPP_HOST_RENAME_SERVER_ACCEPTS_RENAME_TO_ANOTHER_REGISTRARS_DOMAIN
- EPP_HOST_RENAME_SERVER_UNEXPECTEDLY_REJECTS_RENAME

epp-22:
epp-24:
Summary: Host <delete> command test (if applicable)
Description: |
This test will perform `<delete>` commands on the objects created during
Expand All @@ -731,6 +763,6 @@ epp-22:
received from the server, the client will perform `<check>` and `<info>`
commands to confirm that the objects have been deleted.
Dependencies:
- epp-21
- epp-23
Errors:
- EPP_HOST_DELETE_INFO_RESPONSE_OBJECT_STILL_EXISTS
45 changes: 45 additions & 0 deletions inc/epp/errors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1478,3 +1478,48 @@ EPP_HOST_DELETE_INFO_RESPONSE_OBJECT_STILL_EXISTS:
EPP_GREETING_DOES_NOT_MATCH:
Severity: ERROR
Description: TBA

EPP_DOMAIN_UPDATE_INFO_RESPONSE_UNEXPECTED_STATUS_CODE:
Severity: ERROR
Description: TBA

EPP_DOMAIN_UPDATE_INFO_RESPONSE_MISSING_STATUS_CODE:
Severity: ERROR
Description: TBA

EPP_DOMAIN_UPDATE_INFO_RESPONSE_UNEXPECTED_HOST_OBJECT:
Severity: ERROR
Description: TBA

EPP_DOMAIN_UPDATE_INFO_RESPONSE_MISSING_HOST_OBJECT:
Severity: ERROR
Description: TBA

EPP_DOMAIN_UPDATE_INFO_RESPONSE_UNEXPECTED_HOST_ATTRIBUTE:
Severity: ERROR
Description: TBA

EPP_DOMAIN_UPDATE_INFO_RESPONSE_MISSING_HOST_ATTRIBUTE:
Severity: ERROR
Description: TBA

EPP_DOMAIN_UPDATE_INFO_RESPONSE_UNEXPECTED_REGISTRANT:
Severity: ERROR
Description: TBA

EPP_DOMAIN_UPDATE_INFO_RESPONSE_MISSING_REGISTRANT:
Severity: ERROR
Description: TBA

EPP_DOMAIN_UPDATE_INFO_RESPONSE_UNEXPECTED_DNSSEC_DATA:
Severity: ERROR
Description: TBA

EPP_DOMAIN_UPDATE_INFO_RESPONSE_MISSING_DNSSEC_DATA:
Severity: ERROR
Description: TBA

EPP_SERVICE_PORT_NOT_CONSISTENT:
Severity: ERROR
Description: TBA

43 changes: 26 additions & 17 deletions inc/integration/cases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,28 @@ integration-01:
are reflected in the RDAP system within the Service Level Requirement of
the SLA.
The test system will perform RDAP queries to confirm that the RDAP server
provides responses for the domains created in `epp-14`, and host objects
created in `epp-11` (if applicable). The RDAP server **MUST** provide a 200
response within 1 hour of the object's `<crDate>` element.
The test system will connect to the EPP server and create domain and (if
applicable) host and contact objects using the same methodology as `epp-14`
`epp-11`. It will then perform RDAP queries for those objects.
The RDAP server **MUST** provide a 200 response for every object created
within 1 hour of the object's `<crDate>` element.
Input-Parameters:
- epp.hostName
- epp.serverIssuedClientCertificate01
- epp.clid01
- epp.pwd01
- epp.hostModel
- rdap.baseURLs
Dependencies:
- epp-14
- epp-11
Errors:
- EPP_DNS_RESOLUTION_ERROR
- EPP_SERVICE_PORT_UNREACHABLE
- EPP_TLS_CONNECTION_ERROR
- EPP_LOGIN_ERROR
- EPP_XML_PARSE_ERROR
- EPP_GENERIC_COMMAND_ERROR
- EPP_UNEXPECTED_COMMAND_FAILURE
- EPP_SCHEMA_VALIDATION_ERROR
- INTEGRATION_RDAP_REQUEST_FAILED
- INTEGRATION_DOMAIN_NOT_PRESENT_IN_RDAP
integration-02:
Expand All @@ -30,13 +41,13 @@ integration-02:
the SLA.
The test system will perform DNS queries to confirm that the DNS servers
provides responses for the domain names created in `epp-14`. All DNS
servers **MUST** provide the correct DNS response within 1 hour of the
object's `<crDate>` element.
provide responses for the domain names created in `integration-01`. All DNS
servers **MUST** provide the correct DNS response for all domains within 1
hour of the domains's `<crDate>` element.
Input-Parameters:
- dns.nameservers
Dependencies:
- epp-14
- integration-01
Errors:
- INTEGRATION_DNS_QUERY_FAILED
- INTEGRATION_DOMAIN_NOT_PRESENT_IN_DNS
Expand All @@ -58,10 +69,9 @@ integration-03:
listed in the `integration.rdeSFTPACL` resource have been added to the
Access Control List for the SFTP server (if any).
All objects created in the `epp-14` and `epp-11` (if applicable) tests
**MUST** be found within a valid RDE deposit file (that is, the deposit
passes all the tests in the RDE test suite) within 24 hours of each
object's `<crDate>` element.
All objects created in the `integration-01` test case **MUST** be found
within a valid RDE deposit file (that is, the deposit passes all the tests
in the RDE test suite) within 24 hours of each object's `<crDate>` element.
Furthermore, for each deposit found in the directory, the corresponding
RDE report (as described in [Section 2.1 of
Expand All @@ -82,8 +92,7 @@ integration-03:
- integration.rdeSFTPUsername
- integration.rriACL
Dependencies:
- epp-14
- epp-11
- integration-01
Errors:
- INTEGRATION_RDE_SFTP_SERVER_UNREACHABLE
- INTEGRATION_RDE_SFTP_SERVER_AUTHENTICATION_ERROR
Expand Down
2 changes: 2 additions & 0 deletions inc/suites.yaml.in
Original file line number Diff line number Diff line change
Expand Up @@ -282,3 +282,5 @@ StandardIntegrationTest:

TS_PASSFAIL
Test-Cases: ^integration-
Input-Parameters:
- general.minimalPublicDataSet
Loading

0 comments on commit cbe3a8c

Please sign in to comment.