let user can set section which should scrollto #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it a feature or fixing? |
|
I thought it is a feature, but seems like you did't implement it, so i let it can do that |
ibufu
requested changes
Apr 16, 2018
| @@ -33,6 +33,7 @@ export default function install (Vue, options) { | |||
|
|
|||
| options = Object.assign({ | |||
| allowNoActive: false, | |||
| sectionSelector: null, | |||
There was a problem hiding this comment.
我找時間再看一下
現在只是讓我這邊能執行 還沒有考慮過
感謝您的幫忙!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title
i find the initScrollSections method has selector param，but that doesn't pass any config in