-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue155 v070 #156
Open
javiarrobas
wants to merge
51
commits into
master
Choose a base branch
from
issue155_v070
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue155 v070 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to select testcase and store testid in BoptestGymEnv class.
At this point all tests pass when run separately but not together, and only when scaling the server with: docker-compose up --scale worker=3 web provision The reason is that there are some tests that are instantiating two environments: one in the SetUp and another one within the example script invoked, that is, in run_baseline.py, run_sample.py, run_save_callback.py, and partial_test_RL(). The reason why the test work separately but not together I think is because the SetUp() method requests more workers than the server can handle all at once.
environment instances in some cases. Do not test for behavior cloning since a test that fails blocks the server as it still hooks to a worker. Now all tests pass without the need to scale up the server.
…gym-service * commit '187c9a76eefb27cee8285b5cca123aa8f396345f': Check outer observation space and shift index when outs_are_bins=False Set outs_are_bins argument as attribute. Calculate number of bins within bounds as conditional. Add low and high bounds as attribute. Add input argument and documentation.
* master: Update README.md with link to video. Move materials to CCAI Summer School 2022. Change doc by docs Created using Colaboratory - Update tutorial. Created using Colaboratory - update tutorial. Remove wrong tutorial location. Created using Colaboratory Created using Colaboratory Add folder with README.md
* master: Correct inmediate vs immediate instances. Correct typos. Attempt to use master in Colab link. Push notebook from Colab to ensure right link Update link to Colab.
…_updateServiceToBoptestV030 * commit '75e3d5bfb4712e607e5832b147bd74c0fb32e5e7': Use boptest official tag instead of commit to refer to the used boptest version. Read payload in the examples. Read payload in boptestGymEnv.py # Conflicts: # boptestGymEnv.py # examples/run_baseline.py # examples/test_and_plot.py # examples/train_RL.py # testing/test_boptestGymEnv.py
Issue111 update service to boptest v030
…gym-service * commit '80266f4588a9c28137d67b51a7888d0ca3868f01': Set summary file_ref to /testging/references to avoid problems with path. Remove forecast parameters from summary. Request /forecast_points to get all_predictive_vars Change BOPTEST-Gym branch in the Colab badge to work with master. Update tutorial after applying fixes. Add EDIT that clarifies difference with original notebook explained in the recording. Change BOPTEST version in the introductory section. Update tutorial to read payload. # Conflicts: # boptestGymEnv.py # testing/test_boptestGymEnv.py
* issue118_boptestV400: Use point_names list for new API. # Conflicts: # boptestGymEnv.py # examples/test_and_plot.py
* master: Point to master. Rendered using Colaboratory Add reference for DQN_alg. Remove time_rat from reference in Q_alg. Set absolute path for file_ref. Set run_path in executor. Do not convert to plain python code since not needed. Use sys.path.append instead of os.chdir to import boptestGymEnv. sys.path.append is working for both the test and the colab.
…gym-service * commit 'd74faa225ead274333607d93709b41bbee1001d3': (52 commits) Update releasenotes. Change BOPTEST version for testing. Do not add arbitrarily small offset to prediction horizon. Specify nbconvert and ipykernel versions used for testing. Move pulling image functionality to Makefile. Be more clear when describing Gymnasium in tutorial. Fix index out of range error when testing inside Docker container. Revert "Avoid code duplicity in github-actions.yml" Revert "Resolve indentation." Resolve indentation. Avoid code duplicity in github-actions.yml Change only the numpy version. Revert "Change numpy version. " Change numpy version. Reduc logs when building boptest. Revert "Remove --user flag and :rw for safety." Ignore boptest files in testing. unzip quietly. Remove --user flag and :rw for safety. Call classes instead of individual tests. ...
* issue135_v050: Update reference results for numerical differences. Do not duplicate Actions in pull requests. Ensure convertion to regular float since float32 objects of numpy are not JSON serializable. Add command to run boptest without cache. Use json parameter instead of data in requests due to stricter check by Flask REST API. Specify right version in the tutorial. Use tag for versioning boptestgym image. Update BOPTEST commit for testing corresponding to v0.5.0 Use env var for registry image name. # Conflicts: # boptestGymEnv.py # examples/test_and_plot.py
…gym-service * commit '7f5b64fa7a2e8b3fafee6c969b15214af666a3a1': Ensure all objects sent to requests are json serializable using int. Update tutorial results. Add releasenotes. Update references for tutorial. # Conflicts: # boptestGymEnv.py
…gym-service * commit 'b51c56ea23fa0051f092765e236f8faa5d5b1000': Change release date. Remove blank lines. Add versioning and main dependencies section to README.md. Rerender tutorial notebook for correct display of gearing up section. Update DQN results for numerical differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #155.