-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi dimensional action Issue #19 #146
Multi dimensional action Issue #19 #146
Conversation
@IamAniket12 do you think you could add an example and an associated test proving the multi-dimensional action functionality? |
Yes, I can definitely add an example and an associated test proving the multi-dimensional action functionality. Would you prefer it to be in a separate file? @javiarrobas |
Hello @javiarrobas, added a unit test for MultiAction, please review it. Thanks |
Thanks a lot for the contribution @IamAniket12! I'll review it as soon as possible, hopefully by this week. |
@IamAniket12 I see that the only test that is not passing is the test with the vectorized environment, I'm not sure why, but that seems to be due to small numerical differences compared to references so I'm going to have a look to see how to fix that. On the other hand, I'm afraid your test is not triggered yet in GitHub Actions, I'm going configure it to be triggered. |
@IamAniket12 FYI, I've continued your work in this PR: #154. What I've done in summary:
I'm going to close this already as it is completed by the other PR. |
This branch includes code for both Issue 19 and Issue 46.