Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi dimensional action Issue #19 #146

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

IamAniket12
Copy link
Contributor

@IamAniket12 IamAniket12 commented Sep 5, 2024

This branch includes code for both Issue 19 and Issue 46.

@javiarrobas javiarrobas linked an issue Sep 12, 2024 that may be closed by this pull request
@javiarrobas
Copy link
Contributor

@IamAniket12 do you think you could add an example and an associated test proving the multi-dimensional action functionality?

@IamAniket12
Copy link
Contributor Author

IamAniket12 commented Sep 12, 2024

Yes, I can definitely add an example and an associated test proving the multi-dimensional action functionality. Would you prefer it to be in a separate file? @javiarrobas

@IamAniket12
Copy link
Contributor Author

Hello @javiarrobas, added a unit test for MultiAction, please review it. Thanks

@javiarrobas
Copy link
Contributor

Thanks a lot for the contribution @IamAniket12! I'll review it as soon as possible, hopefully by this week.

@javiarrobas
Copy link
Contributor

@IamAniket12 I see that the only test that is not passing is the test with the vectorized environment, I'm not sure why, but that seems to be due to small numerical differences compared to references so I'm going to have a look to see how to fix that. On the other hand, I'm afraid your test is not triggered yet in GitHub Actions, I'm going configure it to be triggered.

@javiarrobas
Copy link
Contributor

@IamAniket12 FYI, I've continued your work in this PR: #154. What I've done in summary:

  • Moved the functionality of your test to examples (I prefer to have it there so it serves as an example as well). See here.
  • Fixed your _get_indices method to account for the number of possible actions instead of the number of bins (see here. This is the reason why the vectorized environment test was not passing.
  • Added an example to explain functionality. See here.
  • Added release notes. See here.

I'm going to close this already as it is completed by the other PR.

@javiarrobas javiarrobas merged commit fbd0661 into ibpsa:master Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform tests with multi-dimensional action space
2 participants