Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed parameter dynFil in borefield models #1886

Merged
merged 1 commit into from
May 21, 2024

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented May 17, 2024

This closes #1885

The entry for the conversion script is

convertModifiers("IBPSA.Fluid.Geothermal.Borefields.BaseClasses.PartialBorefield",
                {"dynFil"}, fill("",0), true);
convertModifiers("IBPSA.Fluid.Geothermal.Borefields.BaseClasses.Boreholes.OneUTube",
                {"dynFil"}, fill("",0), true);
convertModifiers("IBPSA.Fluid.Geothermal.Borefields.BaseClasses.Boreholes.TwoUTube",
                {"dynFil"}, fill("",0), true);

This is for 1885
@mwetter mwetter marked this pull request as ready for review May 17, 2024 20:52
@mwetter
Copy link
Contributor Author

mwetter commented May 17, 2024

@jelgerjansen @FWuellhorst @nytschgeusen : This is a backward incompatible change that avoids confusion due to a parameter having no effect on the simulation. See notes at #1885

Please raise any objections in the next 2 weeks as this is backward incompatible due to the removal of a parameter.

@FWuellhorst
Copy link
Contributor

Fine for AixLib!

@jelgerjansen
Copy link
Contributor

Fine for IDEAS as well!

@nytschgeusen
Copy link
Contributor

Fine for BuildingSystems !

@mwetter mwetter merged commit 3aee124 into master May 21, 2024
3 checks passed
@mwetter mwetter deleted the issue1885_boreFieldFilling branch May 21, 2024 16:45
@FWuellhorst
Copy link
Contributor

@mwetter : Why didn't you create the conversion script and increased the version number of IBPSA?

@mwetter
Copy link
Contributor Author

mwetter commented May 23, 2024

@FWuellhorst : good point. I will make a PR for the update to the conversion script. We increase the number only after an official release and version 4 has not yet been released (https://github.com/ibpsa/modelica-ibpsa/releases) so I left the version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Borefield models allow inconsistent declaration for steady-state calculation of grout
4 participants