-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1707 updates iso13790 #1882
Conversation
Merging master into issue1707
@jelgerjansen, I've just finished revising the code. Please let me know if there is anything else that needs improvement. |
@amaccarini I added some other comments to the revision above. Once you've addressed these, I'll resolve those issues as well. |
@jelgerjansen Thanks for the additional comments! I've just revised the code accordingly. Please let me know if there is anything else. If not, I will start working on the conflict that should be resolved before merging. |
@amaccarini : Yes, this way we can later remove it when |
@mwetter, @jelgerjansen: I removed the block from |
@amaccarini thanks! I noticed you also copied the full documentation section and revision history. Maybe you can replace all of this by referring to the corresponding model in the Modelica Buildings library in the documentation section? |
Michael to have a last look and then merge. |
This is to update the validation of the ISO13790 thermal zone model according to the latest BESTEST documentation. Several BESTEST case studies have been added, along with a Python script that automatically generates plots and tables for the user guide. In addition, a new parameter
coeFac
been added in order to vary the g-factor as a function of the incident angle of the surface.