Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1874 connector to itself and floating point representation #1875

Merged
merged 2 commits into from
May 16, 2024
Merged

Issue1874 connector to itself and floating point representation #1875

merged 2 commits into from
May 16, 2024

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented May 8, 2024

This closes #1874

@mwetter mwetter requested a review from amaccarini May 8, 2024 18:12
@mwetter
Copy link
Contributor Author

mwetter commented May 15, 2024

@amaccarini : Can you please review this PR.

@amaccarini
Copy link
Contributor

amaccarini commented May 16, 2024 •
edited
Loading

@mwetter Sorry for the delay, I might have missed the github notification. Thanks for the reminder!
In the new updates, I've actually removed all those records as the full set of results is now clearly illustrated in IBPSA.ThermalZones.ISO13790.Validation.BESTEST.UsersGuide

@mwetter mwetter merged commit ab8b702 into master May 16, 2024
3 checks passed
@mwetter mwetter deleted the issue1874_connectors_floatingPoints branch May 16, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaccarini amaccarini amaccarini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove connectors to itself, and avoid OCT warning about large integers
2 participants
@mwetter @amaccarini