Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected wrong annotation #1843

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Corrected wrong annotation #1843

merged 4 commits into from
Mar 13, 2024

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented Feb 27, 2024

This closes #1842

@mwetter mwetter requested a review from jelgerjansen March 5, 2024 18:36
Copy link
Contributor

@jelgerjansen jelgerjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Michael

Three minor remarks regarding the icon graphics:

  1. I noticed you now use a dark blue rectangle in the icon, while MediumColumn has a light blue background (that partly changes to red, depending on the choice of densitySelection. Maybe we can change line 120 into fillColor={85,170,255}? Or did you pick another color on purpose?
  2. The texstring "Top" has a larger font than "Bottom" because the font size is not specifically set. This is also the case for Airflow.Multizone.MediumColumn. Explicitly setting the fontsize to 36 gives both strings a font size that corresponds to the current font size of Bottom.
  3. The textstring "name" is not centered in the middle. Again, this is also the case for Airflow.Multizone.MediumColumn.

These are very small (and fussy) comments, so feel free to ignore them ;)

@mwetter mwetter enabled auto-merge March 11, 2024 23:36
@mwetter
Copy link
Contributor Author

mwetter commented Mar 11, 2024

@jelgerjansen : Thanks for the feedback. I addressed them in 995bedb

Can you please review and approve if all is fine so it will merged.

Copy link
Contributor

@jelgerjansen jelgerjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwetter while looking over the changes I noticed another minor icon inaccuracy in MediumColumn, which I fixed in 5ffc308. All other changes look fine by me

@mwetter mwetter merged commit b8d6489 into master Mar 13, 2024
3 checks passed
@mwetter mwetter deleted the issue1842_wrongAnnotation branch March 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MediumColumnDynamic uses non-existent parameter in annotation
2 participants