Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added causality to FMI conversion blocks #1835

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Added causality to FMI conversion blocks #1835

merged 1 commit into from
Feb 6, 2024

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented Feb 2, 2024

This closes #1829

@mwetter mwetter mentioned this pull request Feb 2, 2024
Closed
@mwetter mwetter marked this pull request as ready for review February 5, 2024 14:02
@mwetter mwetter requested a review from jelgerjansen February 5, 2024 15:52
jelgerjansen
jelgerjansen approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@jelgerjansen jelgerjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I also double checked with Dymola 2024x, the validation models seem to work fine.
I would have expected the pedantic check to notify the illegal connection (when the output/input is removed again), but this was not the case.

@mwetter mwetter merged commit 698e04d into master Feb 6, 2024
3 checks passed
@mwetter mwetter deleted the issue1829_causal_acausal branch February 6, 2024 13:03
@mwetter mwetter mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelgerjansen jelgerjansen jelgerjansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection between causal and acausal connectors
2 participants
@mwetter @jelgerjansen