Declared variables on weather bus #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jelgerjansen : This is ready for review. Can you please review as this will also make the tutorial more practical, see 395265e |
jelgerjansen
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Very nice fix Michael, thanks!
I only have one small comment you can have a look at.
Furthermore, I wasn't able to reproduce the error message you mention here when opening the weather data reader itself or a model that contains the reader. When/where did you see this error appearing? (I used version OMEdit v1.21.0)
|
@jelgerjansen : Regarding the error message, this is with 1.22.0~dev-351-g208d900, using |
jelgerjansen
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1798