Issue1575 add pv model #1766
Open
Issue1575 add pv model #1766
+18,132
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proper way to load files is with Modelica.Utilities.Files.loadResource
mwetter
requested changes
Jan 4, 2024
There was a problem hiding this comment.
@LauraMaier : Pleae see the inline comment for the required changes. I still need to run the model (which fail in Dymola 2024x and Optimica, see inline comment for the cause).
IBPSA/Electrical/BaseClasses/PV/BaseClasses/PVOptical/AirMass.mo
Outdated
Show resolved
Hide resolved
IBPSA/Electrical/BaseClasses/PV/BaseClasses/PVOptical/AirMass.mo
Outdated
Show resolved
Hide resolved
IBPSA/Electrical/BaseClasses/PV/BaseClasses/PVOptical/AirMassModifier.mo
Outdated
Show resolved
Hide resolved
IBPSA/Electrical/BaseClasses/PV/BaseClasses/PVOptical/AirMassModifier.mo
Outdated
Show resolved
Hide resolved
Comment on lines
+73
to
+94
| HGloHor=realPassThroughHGloHor.y; | ||
|
|
||
| solHouAng = realPassThroughSolHouAng.y; | ||
| solDec=realPassThroughSolDec.y; | ||
| cloTim=realPassThroughCloTim.y; | ||
|
|
||
| k_t =if HGloHor <= 0.01 | ||
| then 0 | ||
| else min(1, max(0, (HGloHor/(GSC*(1 + 0.033* | ||
| cos(360*(Modelica.Constants.pi/180)*cloTim/24/60/60/365)* | ||
| (cos(lat)*cos(solDec)*cos(solHouAng) + sin(lat)*sin(solDec))))))) | ||
| "Factor needed for Erbs diffuse fraction relation"; | ||
|
|
||
| // Erbs diffuse fraction relation | ||
| HDifHor = if HGloHor <= 0.01 | ||
| then 0 | ||
| elseif k_t <= 0.22 | ||
| then (HGloHor)*(1.0 - 0.09*k_t) | ||
| elseif k_t > 0.8 | ||
| then (HGloHor)*0.165 | ||
| else (HGloHor)* | ||
| (0.9511 - 0.1604*k_t + 4.388*k_t^2 - 16.638*k_t^3 + 12.336*k_t^4); |
There was a problem hiding this comment.
Make these assignments in the variable declaration so that we don't mix connect statements with assignments, and use regularization (also as it is only an example, regularization is less critical here).
IBPSA/Resources/Images/Electrical/DC/Sources/single_diode_scheme.png
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1575
We added a new PV model to the IBPSA library.
The model has the following characteristics: