Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1754 ATES model #1759

Merged
merged 89 commits into from
Oct 20, 2023
Merged

Issue1754 ATES model #1759

merged 89 commits into from
Oct 20, 2023

Conversation

amaccarini
Copy link
Contributor

The PR is about a simplified 1D aquifer thermal energy storage model. There are a couple of things that I cannot fully fix:

  • When I add SingleWell as component, the default unit for pressure is bar. I think it should be Pa, but I am not sure how to fix this.
  • Even though I selected true for the parameter about pressure curves, I still get the warning message.

@amaccarini amaccarini requested a review from mwetter May 25, 2023 09:50
@mwetter
Copy link
Contributor

mwetter commented Jun 2, 2023

  • How would one compute flow distribution if an ATES system has 3 wells? It looks to me like a flow resistance to the ground from well to well is missing.

@mwetter
Copy link
Contributor

mwetter commented Sep 22, 2023

@amaccarini : I think the model is close to being finished.
I changed the model to set the flow resistance on one side to be the same as on the other side, which reduces the amount of equations, and leads to a 1x1 rather than a 2x2 nonlinear system of equations for the initialization.

I have one item I like to discuss, which we can do next week:

  • I think using rMax in the computation of dpAquifer_nominal is not correct: rMax is used for the heat transfer domain, but the wells could be farther away than 2*rMax in which case the resistance should be larger.

@amaccarini
Copy link
Contributor Author

@mwetter Following our discussion last week, I introduced a new parameter d which is the distance between wells. This parameter is used to compute the pressure losses (instead of rMax). The value of rMax is set to d/2 by default.

@mwetter
Copy link
Contributor

mwetter commented Oct 13, 2023

@amaccarini : Should rMax <= d/2 be enforced with an assertion? I noted for example in Examples.CoolingOffice, that d=200 and rMax=500, which I think is not a meaningful configuration.

Also, I assume rMax is the same as r_{Aquifer} in the graphics of the Multiwell documentation. This should be consistent.

@amaccarini
Copy link
Contributor Author

amaccarini commented Oct 14, 2023

@mwetter: Yes, that sounds like a good idea. I added an assertion to verify that rMax <= d/2. I also updated the image by using the names of parameters rWB and rMax.

@mwetter mwetter enabled auto-merge October 18, 2023 21:00
@mwetter mwetter merged commit ec200ac into master Oct 20, 2023
3 checks passed
@mwetter mwetter deleted the issue1754_ATESmodel branch October 20, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants