Skip to content

Commit

Permalink
Corrected documentation and reversed wrong replacement in revision notes
Browse files Browse the repository at this point in the history
  • Loading branch information
@mwetter
mwetter committed Sep 23, 2024
1 parent 27c8c85 commit a92473e
Show file tree
Hide file tree
Showing 12 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/BaseClasses/ActuatorSignal.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ This is for
</li>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredInput</code> to <code>use_strokeTime</code>.<br/>
Renamed <code>filteredInput</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down
4 changes: 2 additions & 2 deletions IBPSA/Fluid/Actuators/BaseClasses/PartialThreeWayValve.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ This is for
</li>
<li>
November 16, 2022, by Michael Wetter:<br/>
Propagated parameter <code>strokeTime</code> to valves. The value is not used as the filter is disabled,
Propagated parameter <code>riseTime</code> to valves. The value is not used as the filter is disabled,
but it will show in the result file. Having a consistent value for all these parameters in the result filter
helps during debugging.
</li>
Expand All @@ -181,7 +181,7 @@ Improved icon graphics annotation. This is for
</li>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredInput</code> to <code>use_strokeTime</code>.<br/>
Renamed <code>filteredInput</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/BaseClasses/PartialTwoWayValve.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ Improved icon graphics annotation. This is for
</li>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredInput</code> to <code>use_strokeTime</code>.<br/>
Renamed <code>filteredInput</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/BaseClasses/PartialTwoWayValveKv.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Removed icon graphics annotation. This is for
</li>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredInput</code> to <code>use_strokeTime</code>.<br/>
Renamed <code>filteredInput</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/Dampers/MixingBox.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ See <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1050\">#1050</a>.
</li>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredInput</code> to <code>use_strokeTime</code>.<br/>
Renamed <code>filteredInput</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/Motors/IdealMotor.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ IBPSA.Fluid.Actuators.UsersGuide</a>.
<ul>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredInput</code> to <code>use_strokeTime</code>.<br/>
Renamed <code>filteredInput</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/Valves/TwoWayPressureIndependent.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ See <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/156\">#156</a>.
</li>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredInput</code> to <code>use_strokeTime</code>.<br/>
Renamed <code>filteredInput</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down
6 changes: 3 additions & 3 deletions IBPSA/Fluid/Actuators/package.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ or damper position is equal to the input signal <code>y</code>.
If <code>use_strokeTime=true</code>, then the actual valve or damper position
changes linear in time until it reaches the control input.
The parameter <code>strokeTime</code>, which by default is set to
<i>120</i> seconds, determines how fast the speed changes.
<i>120</i> seconds, determines how fast the position changes.
For example, if <code>strokeTime=120</code> seconds and the current actuator position is <i>0</i>, then
a step change in the actuator input signal from <i>0</i> to <i>1</i> will
cause the actuator position to change linearly from <i>0</i> to <i>1</i> within
<i>30</i> seconds. Similarly, if the actuator position is then reduced by changing
the input signal from <i>1</i> to <i>0.5</i>, it will take <i>15</i> seconds
<i>120</i> seconds. Similarly, if the actuator position is then reduced by changing
the input signal from <i>1</i> to <i>0.5</i>, it will take <i>60</i> seconds
to achieve the new set point.
</li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Movers/BaseClasses/PartialFlowMachine.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,7 @@ This is for
</li>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredSpeed</code> to <code>use_riseTime</code>.<br/>
Renamed <code>filteredSpeed</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Movers/FlowControlled_dp.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ This is for
</li>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredSpeed</code> to <code>use_riseTime</code>.<br/>
Renamed <code>filteredSpeed</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Movers/FlowControlled_m_flow.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ This is for
</li>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredSpeed</code> to <code>use_riseTime</code>.<br/>
Renamed <code>filteredSpeed</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Movers/SpeedControlled_y.mo
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ This is for
</li>
<li>
March 24, 2017, by Michael Wetter:<br/>
Renamed <code>filteredSpeed</code> to <code>use_riseTime</code>.<br/>
Renamed <code>filteredSpeed</code> to <code>use_inputFilter</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/665\">#665</a>.
</li>
Expand Down

0 comments on commit a92473e

Please sign in to comment.