Skip to content

Commit

Permalink
Use default values for Boolean selectors to avoid errors in OM
Browse files Browse the repository at this point in the history
  • Loading branch information
fabian.wuellhorst committed Nov 18, 2023
1 parent b3792b5 commit 5d91624
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ within IBPSA.Fluid.Chillers.ModularReversible.RefrigerantCycle;
model ConstantQualityGrade "Carnot EER with a constant qualtiy grade"
extends
IBPSA.Fluid.Chillers.ModularReversible.RefrigerantCycle.BaseClasses.PartialChillerCycle(
useInChi=true,
PEle_nominal=QUse_flow_nominal/EER_nominal,
QUseNoSca_flow_nominal=QUse_flow_nominal,
datSou="ConstantQualityGradeCarnot");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@ within IBPSA.Fluid.HeatPumps.ModularReversible.Controls.Safety;
model OnOff
"Controlls if the Safety constraints for on-time, off-time, and cycle rate"
extends BaseClasses.PartialSafety;
parameter Boolean use_minOnTime
parameter Boolean use_minOnTime=true
"=false to ignore minimum on-time constraint"
annotation(choices(checkBox=true));
parameter Modelica.Units.SI.Time minOnTime(displayUnit="min")
"Minimum on-time"
annotation (Dialog(enable=use_minOnTime));
parameter Boolean use_minOffTime
parameter Boolean use_minOffTime=true
"=false to ignore minimum off time constraint"
annotation(choices(checkBox=true));
parameter Modelica.Units.SI.Time minOffTime(displayUnit="min")
"Minimum off time"
annotation (Dialog(enable=use_minOffTime));
parameter Boolean use_maxCycRat
parameter Boolean use_maxCycRat=true
"=false to ignore maximal cycle rate constraint"
annotation(choices(checkBox=true));
parameter Integer maxCycRat "Maximum cycle rate"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ partial model PartialTableData2D
parameter Modelica.Blocks.Types.Extrapolation extrapolation=
Modelica.Blocks.Types.Extrapolation.LastTwoPoints
"Extrapolation of data outside the definition range";
parameter Boolean use_TEvaOutForTab
parameter Boolean use_TEvaOutForTab=true
"=true to use evaporator outlet temperature, false for inlet";
parameter Boolean use_TConOutForTab
parameter Boolean use_TConOutForTab=true
"=true to use condenser outlet temperature, false for inlet";
Modelica.Blocks.Tables.CombiTable2Ds tabPEle(
final tableOnFile=false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ within IBPSA.Fluid.HeatPumps.ModularReversible.RefrigerantCycle;
model ConstantQualityGrade "Carnot COP with a constant qualtiy grade"
extends
IBPSA.Fluid.HeatPumps.ModularReversible.RefrigerantCycle.BaseClasses.PartialHeatPumpCycle(
useInHeaPum=true,
PEle_nominal=QUse_flow_nominal / COP_nominal,
QUseNoSca_flow_nominal=QUse_flow_nominal,
datSou="ConstantQualityGradeCarnot");
Expand Down

0 comments on commit 5d91624

Please sign in to comment.