Added revision notes

ibpsa · Jun 19, 2024 · 2127d26 · 2127d26
1 parent e8d3ff7
commit 2127d26
Show file tree

Hide file tree

Showing 10 changed files with 68 additions and 6 deletions.
diff --git a/IBPSA/BoundaryConditions/WeatherData/Bus.mo b/IBPSA/BoundaryConditions/WeatherData/Bus.mo
@@ -50,6 +50,12 @@ This component is an expandable connector that is used to implement a bus that c
 </html>", revisions="<html>
 <ul>
 <li>
+June 18, 2024, by Michael Wetter:<br/>
+Added <code>start</code> and <code>nominal</code> attributes
+to avoid warnings in OpenModelica due to conflicting values.<br/>
+This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1890\">IBPSA, #1890</a>.
+</li>
+<li>
 September 22, 2023, by Michael Wetter:<br/>
 Declared the variables that are on the bus.<br/>
 This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1798\">IBPSA, #1798</a>.

diff --git a/IBPSA/Fluid/Interfaces/ConservationEquation.mo b/IBPSA/Fluid/Interfaces/ConservationEquation.mo
@@ -430,6 +430,12 @@ IBPSA.Fluid.MixingVolumes.MixingVolume</a>.
 </html>", revisions="<html>
 <ul>
 <li>
+June 18, 2024, by Michael Wetter:<br/>
+Added <code>start</code> and <code>nominal</code> attributes
+to avoid warnings in OpenModelica due to conflicting values.<br/>
+This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1890\">IBPSA, #1890</a>.
+</li>
+<li>
 October 24, 2022, by Michael Wetter:<br/>
 Conditionally removed assertion that checks for water content as this is
 only required if water is added to the medium.<br/>

diff --git a/IBPSA/Fluid/Interfaces/PartialTwoPort.mo b/IBPSA/Fluid/Interfaces/PartialTwoPort.mo
@@ -18,14 +18,18 @@ partial model PartialTwoPort "Partial component with two ports"
   Modelica.Fluid.Interfaces.FluidPort_a port_a(
     redeclare final package Medium = Medium,
      m_flow(min=if allowFlowReversal then -Modelica.Constants.inf else 0),
-     h_outflow(start = Medium.h_default, nominal = Medium.h_default),
+     h_outflow(
+       start = Medium.h_default,
+       nominal = Medium.h_default),
      Xi_outflow(each nominal=0.01))
     "Fluid connector a (positive design flow direction is from port_a to port_b)"
     annotation (Placement(transformation(extent={{-110,-10},{-90,10}})));
   Modelica.Fluid.Interfaces.FluidPort_b port_b(
     redeclare final package Medium = Medium,
     m_flow(max=if allowFlowReversal then +Modelica.Constants.inf else 0),
-     h_outflow(start = Medium.h_default, nominal = Medium.h_default),
+     h_outflow(
+       start = Medium.h_default,
+       nominal = Medium.h_default),
      Xi_outflow(each nominal=0.01))
     "Fluid connector b (positive design flow direction is from port_a to port_b)"
     annotation (Placement(transformation(extent={{110,-10},{90,10}})));
@@ -50,6 +54,12 @@ users have not used this global definition to assign parameters.
 </html>", revisions="<html>
 <ul>
 <li>
+June 18, 2024, by Michael Wetter:<br/>
+Added <code>start</code> and <code>nominal</code> attributes
+to avoid warnings in OpenModelica due to conflicting values.<br/>
+This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1890\">IBPSA, #1890</a>.
+</li>
+<li>
 January 18, 2019, by Jianjun Hu:<br/>
 Limited the media choice.
 See <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1050\">#1050</a>.

diff --git a/IBPSA/Fluid/MixingVolumes/BaseClasses/PartialMixingVolume.mo b/IBPSA/Fluid/MixingVolumes/BaseClasses/PartialMixingVolume.mo
@@ -311,6 +311,12 @@ IBPSA.Fluid.MixingVolumes</a>.
 </html>", revisions="<html>
 <ul>
 <li>
+June 18, 2024, by Michael Wetter:<br/>
+Added <code>start</code> and <code>nominal</code> attributes
+to avoid warnings in OpenModelica due to conflicting values.<br/>
+This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1890\">IBPSA, #1890</a>.
+</li>
+<li>
 October 24, 2022, by Michael Wetter:<br/>
 Improved conversion from <code>Xi</code> to <code>X</code> so that it also works
 with media that have <code>reducedX=true</code>.<br/>

diff --git a/IBPSA/Fluid/Movers/BaseClasses/PartialFlowMachine.mo b/IBPSA/Fluid/Movers/BaseClasses/PartialFlowMachine.mo
@@ -641,6 +641,12 @@ See discussions in
 revisions="<html>
 <ul>
 <li>
+June 18, 2024, by Michael Wetter:<br/>
+Added <code>start</code> and <code>nominal</code> attributes
+to avoid warnings in OpenModelica due to conflicting values.<br/>
+This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1890\">IBPSA, #1890</a>.
+</li>
+<li>
 March 29, 2023, by Hongxiang Fu:<br/>
 Removed the gain block that normalised the speed input
 because it is no longer needed. This is for

diff --git a/IBPSA/Fluid/Sources/BaseClasses/PartialAirSource.mo b/IBPSA/Fluid/Sources/BaseClasses/PartialAirSource.mo
@@ -84,6 +84,12 @@ IBPSA.Fluid.Sources.BaseClasses.PartialSource</a>.
 </html>", revisions="<html>
 <ul>
 <li>
+June 18, 2024, by Michael Wetter:<br/>
+Added <code>start</code> and <code>nominal</code> attributes
+to avoid warnings in OpenModelica due to conflicting values.<br/>
+This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1890\">IBPSA, #1890</a>.
+</li>
+<li>
 January 09, 2023, by Jianjun Hu:<br/>
 First implementation, specifically for the moist air source.<br/>
 This is for

diff --git a/IBPSA/Fluid/Sources/BaseClasses/PartialSource.mo b/IBPSA/Fluid/Sources/BaseClasses/PartialSource.mo
@@ -89,6 +89,12 @@ IBPSA.Fluid.Sources.BaseClasses.PartialAirSource</a>.
 </html>", revisions="<html>
 <ul>
 <li>
+June 18, 2024, by Michael Wetter:<br/>
+Added <code>start</code> and <code>nominal</code> attributes
+to avoid warnings in OpenModelica due to conflicting values.<br/>
+This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1890\">IBPSA, #1890</a>.
+</li>
+<li>
 April 1, 2021, by Michael Wetter:<br/>
 Corrected misplaced <code>each</code> and added missing instance comment.<br/>
 See <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1462\">IBPSA, #1462</a>.

diff --git a/IBPSA/Media/Air.mo b/IBPSA/Media/Air.mo
@@ -95,8 +95,7 @@ package Air
   Modelica.Media.Interfaces.Types.MolarMass MM
     "Molar mass (of mixture or single fluid)";
   ThermodynamicState state(
-    X(nominal={0.01, 1})
-    )
+    X(nominal={0.01, 1}))
     "Thermodynamic state record for optional functions";
 
     Modelica.Units.NonSI.Temperature_degC T_degC=
@@ -1061,6 +1060,12 @@ if <i>T=0</i> &deg;C and no water vapor is present.
 </html>", revisions="<html>
 <ul>
 <li>
+June 18, 2024, by Michael Wetter:<br/>
+Added <code>start</code> and <code>nominal</code> attributes
+to avoid warnings in OpenModelica due to conflicting values.<br/>
+This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1890\">IBPSA, #1890</a>.
+</li>
+<li>
 September 9, 2022, by Michael Wetter:<br/>
 Set nominal attribute for <code>BaseProperties.Xi</code>.<br/>
 This is for

diff --git a/IBPSA/Media/Water.mo b/IBPSA/Media/Water.mo
@@ -21,8 +21,7 @@ package Water "Package with model for liquid water with constant density"
     Modelica.Units.SI.Density d=d_const "Density of medium";
     Temperature T(
       start=293.15,
-      stateSelect=
-        if preferredMediumStates then StateSelect.prefer else StateSelect.default)
+      stateSelect=if preferredMediumStates then StateSelect.prefer else StateSelect.default)
       "Temperature of medium";
     InputAbsolutePressure p "Absolute pressure of medium";
     InputMassFraction[nXi] Xi=fill(0, 0)
@@ -176,6 +175,12 @@ There are no phase changes.
 </html>", revisions="<html>
 <ul>
 <li>
+June 18, 2024, by Michael Wetter:<br/>
+Added <code>start</code> and <code>nominal</code> attributes
+to avoid warnings in OpenModelica due to conflicting values.<br/>
+This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1890\">IBPSA, #1890</a>.
+</li>
+<li>
 September 28, 2020, by Michael Wetter:<br/>
 Reformulated <code>BaseProperties</code> to avoid event-triggering assertions.<br/>
 This is for

diff --git a/IBPSA/Utilities/Psychrometrics/TWetBul_TDryBulPhi.mo b/IBPSA/Utilities/Psychrometrics/TWetBul_TDryBulPhi.mo
@@ -177,6 +177,12 @@ DOI: 10.1175/JAMC-D-11-0143.1
 revisions="<html>
 <ul>
 <li>
+June 18, 2024, by Michael Wetter:<br/>
+Added <code>start</code> and <code>nominal</code> attributes
+to avoid warnings in OpenModelica due to conflicting values.<br/>
+This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1890\">IBPSA, #1890</a>.
+</li>
+<li>
 March 6, 2023, by Michael Wetter:<br/>
 Added a constant in order for unit check to pass.<br/>
 See  <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1711\">#1711</a>