Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove freemarker #28

Draft
wants to merge 1 commit into
base: ibm
Choose a base branch
from

Conversation

AdamBrousseau
Copy link

Signed-off-by: Adam Brousseau [email protected]

Signed-off-by: Adam Brousseau <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

@sxa
Copy link

sxa commented Oct 5, 2021

I don't think this change will actually disable it, only stop it being recorded in the metadata?

(I don't know that piece of code too well, but I doubt it actually affects the attempt to download it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants