Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dev.openjdk on only Linux platforms #138

Draft
wants to merge 1 commit into
base: ibm
Choose a base branch
from

Conversation

Mesbah-Alam
Copy link

Signed-off-by: Mesbah Alam [email protected]

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@Mesbah-Alam
Copy link
Author

@AdamBrousseau - please review.

@Mesbah-Alam Mesbah-Alam force-pushed the enable-dev.openjdk-on-correct-plat branch 2 times, most recently from 599e45c to 20147d0 Compare March 14, 2023 19:58
@Mesbah-Alam Mesbah-Alam force-pushed the enable-dev.openjdk-on-correct-plat branch from 20147d0 to 4e1e90c Compare March 14, 2023 21:58
@Mesbah-Alam Mesbah-Alam marked this pull request as draft March 15, 2023 17:54
@Mesbah-Alam
Copy link
Author

Spoke to Shelley about this. She suggested that this change should happen at upstream, in https://github.com/adoptium/ci-jenkins-pipelines. Otherwise there could be merge conflicts next time we pull changes from upstream. Moving this PR to draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant