Skip to content

Commit

Permalink
chore: add rails 8 support (#61)
Browse files Browse the repository at this point in the history
* chore: add rails 8 support

* bundle install

* Fix lint

* Lint

* gem description

* Gemfile.lock

* Reset lint.yml

* Rubocop

* Version

* Dont use cache

* add back cache?

* Maybe

* gemfile

* Debug

* debug

* Maybe fix
  • Loading branch information
michaelroudnitski authored Jan 2, 2025
1 parent 14b3317 commit 76c80c9
Show file tree
Hide file tree
Showing 6 changed files with 147 additions and 116 deletions.
21 changes: 9 additions & 12 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,21 @@
name: Lint
on: [pull_request]
on:
pull_request:
permissions:
contents: read
pull-requests: write
jobs:
lint:
name: Rubocop
name: Lint
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2
bundler-cache: true
- name: rubocop
uses: reviewdog/action-rubocop@v2
with:
rubocop_version: gemfile
rubocop_extensions: rubocop-performance:gemfile rubocop-rails:gemfile rubocop-github:gemfile rubocop-rspec:gemfile
# erb-lint has issues with Alpine (of which is used extensively throughout our products), follow the following issues before re-enabling:
# https://github.com/Shopify/erb-lint/issues/221
# https://github.com/Shopify/better-html/issues/69
# - name: erb-lint
# uses: ./.github/actions/erblint
# with:
# rubocop_extensions: rubocop-performance:gemfile rubocop-rails:gemfile rubocop-github:gemfile
skip_install: true
use_bundler: true
2 changes: 2 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ AllCops:
SuggestExtensions: false
Exclude:
- 'spec/**/*'
- 'vendor/**/*'

Style/StringLiterals:
EnforcedStyle: double_quotes
Expand All @@ -35,3 +36,4 @@ Lint/MissingSuper:
Exclude:
- 'app/components/**/*'
- 'app/services/**/*'

2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2
ruby 3.3.6
Loading

0 comments on commit 76c80c9

Please sign in to comment.