Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logistration page redesign #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

serhatgktp
Copy link
Collaborator

Description

Implemented the Login and Register pages from our Cognitive Class figma wireframe.

The empty buttons will be replaced with SSO buttons and the logo at the left-top will be replaced with the CC logo once we use tutor to host this rendition of the login/registration pages.

There are several snippets in the code marked with SN-TODO: that must be taken care of before deploying to production.

Zenhub

Issue #3423

How Has This Been Tested?

The changes are yet to be tested with tutor.

To run the build locally, do the following:

  1. Install EdX Devstack (takes a while)
git clone https://github.com/openedx/devstack
cd devstack
make dev.clone
make dev.pull.frontend-app-authn
make dev.provision
make dev.up.frontend-app-authn    # Runs docker containers required to launch this module
  1. Run frontend-app-authn locally
git clone https://github.com/ibm-skills-network/frontend-app-authn
cd frontend-app-authn
npm install
npm start
  1. Visit localhost:1999

Screenshots/sandbox (optional):

Before:

image
image

After:

image
image

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

serhatgktp added 7 commits August 1, 2023 15:21
Some settings were temporarily altered to visualize certain elements in the DOM that otherwise would not have been visible. Each temporarily altered setting is preceded with a 'SN-TODO' table and should be reverted before deploying to production.

Signed-off-by: serhatgktp <[email protected]>
There are some temporary variables and settings that I set manually to visualize some of the objects in the DOM. They are marked with SN-TODO, and each instance must be reverted before deploying to production.

Signed-off-by: serhatgktp <[email protected]>
Signed-off-by: serhatgktp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant