Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled the selection till save is success for bios setting #180

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

Renuka9527
Copy link

@Renuka9527 Renuka9527 commented Feb 1, 2024

Description: Disabled the selection till save is success for bios setting
Defect: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=595828

github Issue: ibm-openbmc/openbmc#291

Copy link
Collaborator

@Nikhil-Ashoka Nikhil-Ashoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have linux KVM percentage dropdown as well. Instead of disabling everything in the page, We can try to remove the get call that is causing the issue.

@Renuka9527
Copy link
Author

We have linux KVM percentage dropdown as well. Instead of disabling everything in the page, We can try to remove the get call that is causing the issue.

Addressed

@Nikhil-Ashoka
Copy link
Collaborator

I think we still have to keep the disabled implementation in this page. The change we made might not reproduce the issue in our systems, but will happen in some systems

@Renuka9527
Copy link
Author

I think we still have to keep the disabled implementation in this page. The change we made might not reproduce the issue in our systems, but will happen in some systems

Addressed

@Nikhil-Ashoka Nikhil-Ashoka self-requested a review February 22, 2024 15:13
@rfrandse rfrandse merged commit 1375476 into ibm-openbmc:1060 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants