Everest:Missing EXP_PRSNT GPIO pin for PCIe cards #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PriyangaRamasamy
requested review from
jinuthomas,
souvik1914581,
SunnySrivastava1984,
RekhaAparna01 and
branupama
PriyangaRamasamy
force-pushed
the
everest-json-pcie-changes
branch
from
d8a6047
to
98abaf9
Compare
In everest VPD JSON, "presence" section with expander presence gpio pin information is missing for PCIe cards. Due to which during FRU VPD collection, I2C line for PCIe card VPD is enabled without checking if IBM specific PCIe card is actually present on the system. This check is required for PCIe cards because the PCIe slot accepts both IBM specific cards and any industry standard cards. So during VPD collection before enabling the I2C line of PCIe card VPD, it's recommended to check if IBM standard PCIe card is present on IBM system. Test: busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager com.ibm.VPD.Manager CollectFRUVPD o "/xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot2/pcie_card2" Oct 16 13:10:40 ever6bmc vpd-manager[1929]: Manager called to collect vpd for fru: /xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot2/pcie_card2 Oct 16 13:10:40 ever6bmc vpd-manager[1929]: Setting GPIO: presence-cable-card2 to 1 Oct 16 13:10:40 ever6bmc vpd-manager[1929]: Executing driver binding for chip address - 17-0060 Oct 16 13:10:40 ever6bmc kernel: at24 17-0050: 8192 byte 24c64 EEPROM, writable, 1 bytes/write Oct 16 13:10:40 ever6bmc kernel: leds-pca955x 17-0060: leds-pca955x: Using pca9551 8-bit LED driver at slave address 0x60 Oct 16 13:10:40 ever6bmc kernel: leds-pca955x 17-0060: gpios 1040...1047 Oct 16 13:10:40 ever6bmc systemd[1]: Started IPZ format VPD Parser service for FRU sys/devices/platform/ahb/ahb:apb/ahb:apb:bus@1e78a000/1e78a280.i2c-bus/i2c-4/i2c-17/17-0050/17-005060. Oct 16 13:10:40 ever6bmc systemd[1]: Started Phosphor sysfs LED controller. Oct 16 13:10:40 ever6bmc systemd[1]: Started Phosphor sysfs LED controller. Oct 16 13:10:41 ever6bmc systemd[1]: ibm-vpd-parser@sys-devices-platform-ahb-ahb:apb-ahb:apb:bus\x401e78a000-1e78a280.i2c\x2dbus-i2c\x2d4-i2c\x2d17-17\x2d0050-17\x2d005060.service: Deactivated successfully. Signed-off-by: Priyanga Ramasamy <[email protected]>
PriyangaRamasamy
force-pushed
the
everest-json-pcie-changes
branch
from
98abaf9
to
b052b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In everest VPD JSON, "presence" section with expander presence gpio pin information is missing for PCIe cards. Due to which during FRU VPD collection, I2C line for PCIe card VPD is enabled without checking if IBM specific PCIe card is actually present on the system.
This check is required for PCIe cards because the PCIe slot accepts both IBM specific cards and any industry standard cards. So during VPD collection before enabling the I2C line of PCIe card VPD, it's recommended to check if IBM standard PCIe card is present on IBM system.
Test:
busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager com.ibm.VPD.Manager CollectFRUVPD o "/xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot2/pcie_card2"
Oct 16 13:10:40 ever6bmc vpd-manager[1929]: Manager called to collect vpd for fru: /xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot2/pcie_card2
Oct 16 13:10:40 ever6bmc vpd-manager[1929]: Setting GPIO: presence-cable-card2 to 1
Oct 16 13:10:40 ever6bmc vpd-manager[1929]: Executing driver binding for chip address - 17-0060
Oct 16 13:10:40 ever6bmc kernel: at24 17-0050: 8192 byte 24c64 EEPROM, writable, 1 bytes/write
Oct 16 13:10:40 ever6bmc kernel: leds-pca955x 17-0060: leds-pca955x: Using pca9551 8-bit LED driver at slave address 0x60
Oct 16 13:10:40 ever6bmc kernel: leds-pca955x 17-0060: gpios 1040...1047
Oct 16 13:10:40 ever6bmc systemd[1]: Started IPZ format VPD Parser service for FRU sys/devices/platform/ahb/ahb:apb/ahb:apb:bus@1e78a000/1e78a280.i2c-bus/i2c-4/i2c-17/17-0050/17-005060.
Oct 16 13:10:40 ever6bmc systemd[1]: Started Phosphor sysfs LED controller.
Oct 16 13:10:40 ever6bmc systemd[1]: Started Phosphor sysfs LED controller.
Oct 16 13:10:41 ever6bmc systemd[1]: ibm-vpd-parser@sys-devices-platform-ahb-ahb:apb-ahb:apb:bus\x401e78a000-1e78a280.i2c\x2dbus-i2c\x2d4-i2c\x2d17-17\x2d0050-17\x2d005060.service: Deactivated successfully.