Support for DDR4 DDIMM parsing #422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branupama
force-pushed
the
dd4_ddimm
branch
2 times, most recently
from
4b9b8df
to
af91aa6
Compare
branupama
requested review from
jinuthomas,
PriyangaRamasamy,
souvik1914581 and
SunnySrivastava1984
This commit adds the code to support parsing of DDR4 DDIMM type VPD. ParserFactory is updated to handle the DDR4 type to get the DDIMM VPD parsing instance for DDR4 DDIMM and DdimmVpdParser class updated to handle DDR4 DDIMM VPD parsing with new API to calculate the DDR4 DDIMM size. Unit test case for DDR4 DDIMM VPD file is added, observed unit test case is got passed. Tested the changes by running vpd-manager application, observed DDIMM parser is selected for DDR4 DDIMM EEPROM files and parsing is successful. And also observed, DDIMM size is calculated correctly for DDR4 DDIMMs. Signed-off-by: Anupama B R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the code to support parsing of DDR4 DDIMM type VPD.
ParserFactory is updated to handle the DDR4 type to get the DDIMM VPD
parsing instance for DDR4 DDIMM and DdimmVpdParser class updated to
handle DDR4 DDIMM VPD parsing with new API to calculate the
DDR4 DDIMM size.
Tested the changes by running vpd-manager application, observed DDIMM
parser is selected for DDR4 DDIMM EEPROM files and parsing is
successful. And also observed, DDIMM size is calculated correctly
for DDR4 DDIMMs.