CFAM: Put sibling values on D-Bus #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates a SiblingBMC class to poll the sibling CFAMs and put the values on D-Bus. The D-Bus details are: service: xyz.openbmc_project.State.BMC.Redundancy.Sibling interface: xyz.openbmc_project.State.BMC.Redundancy.Sibling object path: /xyz/openbmc_projec/state/bmc1 A service file to run the application named after the D-Bus service is now included. For now, the SiblingBMC class is created if any CFAM off of link 1 is present. In the future when more is known about the system, there may need to be changes to identify that CFAM as one on a BMC card, and possibly even look at other links for the BMC's CFAM. To ensure that D-Bus clients are getting valid values, the interface won't be created until the CFAM is successfully read, and will be removed if the CFAM cannot be accessed. Tested: ``` $ busctl introspect -l xyz.openbmc_project.State.BMC.Redundancy.Sibling /xyz/openbmc_project/state/bmc1 NAME TYPE SIGNATURE RESULT/VALUE FLAGS xyz.openbmc_project.State.BMC.Redundancy.Sibling interface - - - .BMCPosition property u 1 emits-change .BMCState property s "xyz.openbmc_project.State.BMC.BMCState.Quiesced" emits-change .CommsOK property b true emits-change .FWVersion property s "DD59CE3D" emits-change .FailoversPaused property b false emits-change .Heartbeat property b true emits-change .Provisioned property b false emits-change .RedundancyEnabled property b false emits-change .Role property s "xyz.openbmc_project.State.BMC.Redundancy.Role.Passive" emits-change ``` and fields accurately reflect the values in the CFAM. Change-Id: I4cd171b737e2f63353fd5317b7ff694cfa4dd37e Signed-off-by: Matt Spinler <[email protected]>
RameshIyyar
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates a SiblingBMC class to poll the sibling CFAMs and put the values on D-Bus. The D-Bus details are:
service: xyz.openbmc_project.State.BMC.Redundancy.Sibling
interface: xyz.openbmc_project.State.BMC.Redundancy.Sibling
object path: /xyz/openbmc_projec/state/bmc1
A service file to run the application named after the D-Bus service is now included.
For now, the SiblingBMC class is created if any CFAM off of link 1 is present. In the future when more is known about the system, there may need to be changes to identify that CFAM as one on a BMC card, and possibly even look at other links for the BMC's CFAM.
To ensure that D-Bus clients are getting valid values, the interface won't be created until the CFAM is successfully read, and will be removed if the CFAM cannot be accessed.
Tested:
and fields accurately reflect the values in the CFAM.
Change-Id: I4cd171b737e2f63353fd5317b7ff694cfa4dd37e