MQ V2 OSS release #136
Merged
MQ V2 OSS release #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squash and merge of exactly once work, history is available in the onlyOnce-history branch
Contributes to: event-integration/qp-planning#10883 Signed-off-by: Joel Hanson <[email protected]>
* fix:L Include appropriate license in packaging Include appropriate license in packaging Contributes to: event-integration/eventstreams-planning#11171 Signed-off-by: neeraj-laad<[email protected]> Signed-off-by: neeraj-laad <[email protected]> * fix: Move Licenses folder under META-INF Move Licenses folder under META-INF Contributes to: event-integration/eventstreams-planning#11171 Signed-off-by: neeraj-laad <[email protected]> * fix: update license in README update license in README Contributes to: event-integration/eventstreams-planning#11171 Signed-off-by: neeraj-laad <[email protected]>
We use the latest tag MQ image in our integration tests. In December, MQ's container image removed the no-auth svrconn channel so this breaks the connector tests that try to make connections to MQ without credentials. This commit adds a custom MQSC script to configure the queue manager to restore the previous behaviour. The MQSourceTaskAuthIT tests still test the ability to connect to a queue manager with auth credentials, so this commit means we still test connecting with and without credentials. Contributes-to: event-integration/eventstreams-planning#12427 Signed-off-by: Dale Lane <[email protected]>
* feat: pull in changes from origin Contributes to: event-integration/eventstreams-planning#12467 Signed-off-by: Joel Hanson <[email protected]> * feat: Fix suggested review comments Contributes to: event-integration/eventstreams-planning#12467 Signed-off-by: Joel Hanson <[email protected]> --------- Signed-off-by: Joel Hanson <[email protected]>
…ibm-messaging#51) * chore: comment updates - no functional changes Fixed some weird line-wrapping in the existing comments, edited comments that were technically inaccurate, and added some extra clarification to comments ahead of changes in the next commit. Signed-off-by: Dale Lane <[email protected]> * test: new unit tests that illustrate desired behaviour poll() should quickly return an empty list if we are still waiting for a previous batch to complete, but throw an exception if this happens too many times. Signed-off-by: Dale Lane <[email protected]> * fix: avoid deadlocking poll calls when commitRecord isnt called Signed-off-by: Dale Lane <[email protected]> * chore: prepare new release I also removed an invalid config option that was included in the pom.xml at some point. Signed-off-by: Dale Lane <[email protected]> * feat: Address review comments Contributes to: event-integration/eventstreams-planning#0 Signed-off-by: Joel Hanson <[email protected]> * fix: Update kafka connect-api and connect-json version Contributes to: event-integration/eventstreams-planning#0 Signed-off-by: Joel Hanson <[email protected]> --------- Signed-off-by: Dale Lane <[email protected]> Signed-off-by: Joel Hanson <[email protected]> Co-authored-by: Joel Hanson <[email protected]>
Contributes to: event-integration/eventstreams-planning#0 Signed-off-by: Joel Hanson <[email protected]>
Contributes to: event-integration/eventstreams-planning#0 Signed-off-by: Joel Hanson <[email protected]>
…ce/main' into mqv2-ossrelease
neeraj-laad
reviewed
Jul 23, 2024
| @@ -57,8 +57,8 @@ body: | |||
| label: Version | |||
| description: What version of our software are you running? | |||
| options: | |||
| - 1.3.5 (Default) | |||
| - older (<1.3.5) | |||
| - 2.0.0 (Default) | |||
There was a problem hiding this comment.
should this list all 2.x versions or should we simply rename the entry to include all 2.x releases?
neeraj-laad
reviewed
Jul 23, 2024
.travis.yml
Outdated
| @@ -3,4 +3,4 @@ language: java | |||
| services: | |||
| - docker | |||
|
|
|||
| script: mvn clean verify | |||
| script: mvn clean verify | |||
There was a problem hiding this comment.
no meaningful change here. is this needed?
neeraj-laad
reviewed
Jul 23, 2024
Dockerfile
Outdated
| && tar -xf kafka.tgz -C /opt/kafka --strip-components=1 | ||
|
|
||
| FROM ibmjava:11 | ||
| FROM ibmjava:8-jre |
There was a problem hiding this comment.
Why move from from Java 11 to Java 8?
neeraj-laad
reviewed
Jul 23, 2024
src/assembly/package.xml
Outdated
| @@ -23,12 +23,6 @@ | |||
| <format>jar</format> | |||
| </formats> | |||
| <includeBaseDirectory>false</includeBaseDirectory> | |||
| <files> | |||
There was a problem hiding this comment.
Is the license packaged in a different way?
Joel-hanson
reviewed
Jul 24, 2024
Joel-hanson
reviewed
Jul 24, 2024
Joel-hanson
reviewed
Jul 24, 2024
Joel-hanson
reviewed
Jul 24, 2024
Joel-hanson
requested changes
Jul 24, 2024
Joel-hanson
reviewed
Jul 31, 2024
Joel-hanson
reviewed
Jul 31, 2024
Joel-hanson
requested changes
Jul 31, 2024
src/integration/java/com/ibm/eventstreams/connect/mqsource/SequenceStateClientIT.java
Outdated
Show resolved
Hide resolved
Joel-hanson
requested changes
Aug 6, 2024
Contributes to: event-integration/eventstreams-planning#12988 Signed-off-by: Priyanka.K.U [email protected] feat: updated versions in pom.xml Contributes to: event-integration/eventstreams-planning#12988 Signed-off-by: Priyanka.K.U [email protected] feat: Addressing review comments Contributes to: event-integration/eventstreams-planning#12988 Signed-off-by: Priyanka.K.U [email protected] feat: Addressing review comments Contributes to: event-integration/eventstreams-planning#12988 Signed-off-by: Priyanka.K.U [email protected] Updated BUG Report Template Contributes to: event-integration/eventstreams-planning#12988 Signed-off-by: Priyanka.K.U [email protected] feat: updated copyright year 2024 Contributes to: event-integration/eventstreams-planning#12988 Signed-off-by: Priyanka.K.U [email protected] feat: addressed the review comments and updated the version to 2.1.0 Contributes to: event-integration/eventstreams-planning#12988 Signed-off-by: Priyanka.K.U [email protected] feat: updated the License folder Contributes to: event-integration/eventstreams-planning#12988 Signed-off-by: Priyanka.K.U [email protected] feat: Updated License and Travis for MQ 2.0.2 Contributes to: event-integration/eventstreams-planning#12988 Signed-off-by: Priyanka.K.U [email protected]
priyankaku
force-pushed
the
mqv2-ossrelease
branch
from
a22bf9f
to
55fb578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release MQ v2 source connector under apache 2.0 license.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist