-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combobox: multiple fixes. #674
Changes from 1 commit
b4e53a5
b0199b3
ff26def
23c5824
80e6270
3f36ca1
50a0edf
95a0fb2
4d46111
49fabb6
1ff8cb7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -984,6 +984,7 @@ define([ | |
} | ||
this.dropDown.focus(); | ||
} | ||
|
||
}.bind(this)); | ||
}; | ||
}), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -612,6 +612,43 @@ define([ | |
return d; | ||
}, | ||
|
||
"inputNode: aria-expanded attribute on open/close popup": function () { | ||
var combo = new Combobox({labelAttr: "name"}); | ||
var dataSource = new Memory( | ||
{idProperty: "name", | ||
data: [ | ||
{ name: "Japan", sales: 900, profit: 100, region: "Asia" }, | ||
{ name: "France", sales: 500, profit: 50, region: "EU" }, | ||
{ name: "Germany", sales: 450, profit: 48, region: "EU" }, | ||
{ name: "UK", sales: 700, profit: 60, region: "EU" }, | ||
{ name: "USA", sales: 2000, profit: 250, region: "America" }, | ||
{ name: "Canada", sales: 600, profit: 30, region: "America" }, | ||
{ name: "Brazil", sales: 450, profit: 30, region: "America" }, | ||
{ name: "China", sales: 500, profit: 40, region: "Asia" } | ||
]}); | ||
combo.source = dataSource; | ||
container.appendChild(combo); | ||
combo.attachedCallback(); | ||
combo.deliver(); | ||
|
||
var d = this.async(2000); | ||
console.log(combo.inputNode); | ||
assert.strictEqual(combo.inputNode.getAttribute("aria-expanded"), "false", | ||
"aria-expanded - popup is closed: " + combo.id); | ||
|
||
combo.openDropDown().then(d.rejectOnError(function () { | ||
assert.strictEqual(combo.inputNode.getAttribute("aria-expanded"), "true", | ||
"aria-expanded - popup is open: " + combo.id); | ||
combo.closeDropDown(); | ||
setTimeout(d.callback(function () { | ||
assert.strictEqual(combo.inputNode.getAttribute("aria-expanded"), "false", | ||
"aria-expanded - popup is closed: " + combo.id); | ||
}), 200); | ||
})); | ||
|
||
return d; | ||
}, | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got this error after running grunt test:remote (with this changeset only): × internet explorer 11 on Windows 8.1 - unit tests - deliteful/Combobox: programatic - inputNode: aria-expanded attribute on open/close popup (0.046s) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this happens only in IE11? |
||
// Test case for #509: initialization of Combobox after List rendering is ready. | ||
// "initialization with List rendering after Combobox initialization": function () { | ||
// var combo = new Combobox(); // single selection mode | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be there.