fix not working url encoding function in Utils #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our work with the AppID SDK for mobile client we found out that email addresses with plus sign works on Android but not on iOS. For Example the email address [email protected].
After I analyse the problem, I found out that the function urlEncoding in the Utils didn't work correctly. The returning output string of the function is the same as the input string to the function.
I have fix the problem with a urlEncoding and I had make the change in the RegistrationManager for running the SDK correctly. The JSON which was before given into the urlEncoding function, has no changes make on the JSON, so I have remove this unnessary function call.